fix(spec2cdk): use modern type when building tag type #29389
Conversation
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
| @@ -179,7 +179,7 @@ export class ResourceDecider { | |||
|
|
|||
| private handleTagPropertyModern(cfnName: string, prop: Property, variant: TagVariant) { | |||
| const originalName = propertyNameFromCloudFormation(cfnName); | |||
| const originalType = this.converter.typeFromProperty(prop); | |||
| const originalType = this.converter.typeFromPropertyForModernTags(prop); | |||
There was a problem hiding this comment.
This should be safe and not a breaking change because handleTagPropertyModern is only enabled in version 2.131.0 which is the current CDK version, see this PR https://github.com/aws/aws-cdk/pull/28989/files.
Before version 2.131.0 there would be no way to reach this function call due to HAS_25610 is always set to false (see the PR I linked). And for 2.131.0 there wouldn't be a deployable template since it will fails at deployment step, see description.
GavinZZ
added
pr-linter/exempt-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
github-actions
bot
added
effort/medium
aws-cdk-automation
added
the
pr/needs-maintainer-review
aws-cdk-automation
removed
the
pr/needs-maintainer-review
GavinZZ
removed
the
pr-linter/exempt-test
Thanks, I've added unit tests to the |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Issue # (if applicable)
Closes #29388
Reason for this change
Some of the modern tags failed to run
cdk synthdue to type misconfiguration.Description of changes
Always default to use the latest type for modern tags.
Description of how you validated changes
Fixed for failed resources.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license