fix(stepfunctions): the catch field in CustomState is not rendered #29654
Conversation
github-actions
bot
added
the
beginning-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
|
|
||
| describe('Custom State', () => { | ||
| describe.only('Custom State', () => { |
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
| @@ -309,4 +310,145 @@ describe('Custom State', () => { | |||
| }, | |||
| ); | |||
| }); | |||
|
|
|||
| test('expect retry to merge when specifying strategy inline and through construct', () => { | |||
There was a problem hiding this comment.
(non-blocking) this is already covered as part of this test:
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Issue # (if applicable)
N/A
Reason for this change
Customers that specify
Catchfields in their CustomState'sstateJsondo not have Catchers defined in the rendered state definition. The reason for this is that theCatchfields from thestateJsonis overridden by Catchers added throughaddCatch().Description of changes
This change updates the way the state's
Catchfield is rendered to merge Catchers provided inline with those provided throughaddCatch(). Catchers fromaddCatch()will be rendered first, followed by those provided inline. This is consistent with the merge behaviour for Retriers.Description of how you validated changes
Unit test coverage for Catchers provided just inline, just through
addCatch(), and a combination of both.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license