-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ec2): update WindowsVersions enum #29796
base: main
Are you sure you want to change the base?
Conversation
This reverts commit e71e79d.
This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
Hi This PR has been pending for community review for a while. Please consider posting it on the #contributing channel in cdk.dev. Community members will be on the lookout there as well for possible reviews. Check How to get your P2 PR community reviewed for more details. |
This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
Comments on closed issues and PRs are hard for our team to see. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #29796 +/- ##
=======================================
Coverage 78.66% 78.66%
=======================================
Files 107 107
Lines 7161 7161
Branches 1320 1320
=======================================
Hits 5633 5633
Misses 1343 1343
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
None
Reason for this change
Update the CDK EC2 listed Windows versions to match the current availability. Follow up to #29435, which was reverted for erroneous changes.
This version in based on the
/aws/service/ami-windows-latest/*
SSM parameters, similarly to #29738.Description of changes
WindowsVersion
enum:jsii
andjsii-reflect
dependencies to@aws-cdk-testing/framework-integ
Description of how you validated changes
The
WindowsVersion
values were compared to the SDK results ofssm:GetParametersByPath
with the following params:The parameters that did not start with
/aws/service/ami-windows-latest/Windows_Server
were ignored. Some are Amazon Linux images:amzn2-ami-hvm-2.0.*
amzn2-x86_64-SQL_2019_*
Others are either EC2LaunchV2 or NitroTPM Windows images, neither currently supported by the CDK:
EC2LaunchV2-Windows_Server-2016-English-*
TPM-Windows_Server-2016-English-*
TPM-Windows_Server-2019-English-*
TPM-Windows_Server-2022-English-*
Also went a little crazy on the integration, it checks all of the listed
WindowsVersion
and:/aws/service/ami-windows-latest/<version>
parameterThis ensures that a situation like #29736 (comment) does not happen again
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license