fix(batch): allow endNode to be optional for multinode containers
#29849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
comcalvi
changed the title
endNode to be optional for multinode containers
aws-cdk-automation
previously requested changes
Apr 15, 2024
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
comcalvi
changed the title
endNode to be optional for multinode containersendNode to be optional for multinode containers
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
ah...naturally weakening a property is a breaking change |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #29415
Reason for this change
The Batch L2 forces users to specify endNode, even though this is technically optional, on batch multinode jobs. This was initially done intentionally, since with endNode we can compute the always-required
numNodesfor the user.numNodescan be overwritten when actually submitting a job, but only if the job has at least one container withendNodeomitted.If any container omits
endNode, we can no longer computenumNodes, which is a required property; in this case, the user must specify it.Description of changes
Adds a new optional property,
numNodes, and makesendNodeoptional on multinode containers.Description of how you validated changes
unit and integration tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license