Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test that @aws-cdk/custom-resource-handlers unit tests will fail build if unit tests fail #29859

Closed
wants to merge 1 commit into from
Closed

chore: test that @aws-cdk/custom-resource-handlers unit tests will fail build if unit tests fail #29859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@aws-cdk/custom-resource-handlers/test/aws-eks/cluster-resource-provider.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ describe('cluster resource provider', () => {
const handler = new ClusterResourceHandler(mocks.client, mocks.newRequest('Update'));
mocks.simulateResponse.describeClusterResponseMockStatus = 'UPDATING';
const resp = await handler.isComplete();
expect(resp.IsComplete).toEqual(false);
expect(resp.IsComplete).toEqual(true);
});

test('isUpdateComplete waits for ACTIVE', async () => {
Expand Down
4 changes: 2 additions & 2 deletions packages/@aws-cdk/custom-resource-handlers/test/aws-s3/auto-delete-objects-handler.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,8 +460,8 @@ test('delete event where bucket has many objects does recurse appropriately', as
Bucket: 'MyBucket',
Delete: {
Objects: [
{ Key: 'Key3', VersionId: 'VersionId3' },
{ Key: 'Key4', VersionId: 'VersionId4' },
{ Key: 'Key1', VersionId: 'VersionId1' },
{ Key: 'Key2', VersionId: 'VersionId2' },
],
},
});
Expand Down
4 changes: 2 additions & 2 deletions packages/@aws-cdk/custom-resource-handlers/test/nodejs-entrypoint.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@ describe('nodejs entrypoint', () => {
expect(response.Status).toEqual('SUCCESS');
expect(response.PhysicalResourceId).toEqual('<RequestId>');
expect(response.Data).toEqual({
Attribute1: 'hello',
Attribute1: 'goodbye',
Attribute2: {
Foo: 1111,
Foo: 2222,
},
});
});
Expand Down
Loading