chore: align all versions of typescript, jsii & jsii-rosetta to 5.4 #29974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
commented
Apr 26, 2024
| @@ -28,7 +28,6 @@ | |||
| "jsii-diff": "1.97.0", | |||
| "jsii-pacmak": "1.97.0", | |||
| "jsii-reflect": "1.97.0", | |||
| "jsii-rosetta": "~5.4.2", | |||
There was a problem hiding this comment.
Moved to cdk-build-tools as centralized place for jsii stuff. This is where the only jsii dependency was before as well.
mrgrain
force-pushed
the
mrgrain/chore/align-jsii-ts-versions
branch
from
f08fb76 to
34e1648
Compare
aws-cdk-automation
added
the
pr/needs-maintainer-review
mrgrain
force-pushed
the
mrgrain/chore/align-jsii-ts-versions
branch
from
34e1648 to
f2910a8
Compare
mrgrain
changed the title
mrgrain
force-pushed
the
mrgrain/chore/align-jsii-ts-versions
branch
from
f2910a8 to
b514eb7
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This was referenced Apr 29, 2024
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this change
There were a number of inconsistencies with the versions used for typescript, jsii & jsii-rosetta in this repository.
Also the automated updater was incorrectly updating jsii minor versions.
I did some digging and turns out because
jsiiwas at5.4.xalready, we are already using TypeScript 5.4 for most critical paths. So I went ahead and aligned all TS version on that.Description of changes
Manually align all versions of typescript, jsii & jsii-rosetta.
Fixed the update workflow to only update patch version for these three packages.
Includes changes from #29978 until that is merged, and this PR is rebased.
Description of how you validated changes
Run through the test pipeline.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license