-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(rds): update engine versions #30305
Conversation
/** Version "5.7.44-rds.20240408". */ | ||
public static readonly VER_5_7_44_RDS_20240408 = MysqlEngineVersion.of('5.7.44-rds.20240408', '5.7'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See announcement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like there is extended support for version 5.7.44-RDS.20240529 as well now, could we update this PR to include the latest versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for letting me know, I've updated them 👍
/** | ||
* Version "11.12-rds.20240418" | ||
*/ | ||
public static readonly VER_11_12_RDS_20240418 = PostgresEngineVersion.of('11.12-rds.20240418', '11', { s3Import: true, s3Export: true }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See announcement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nmussy, thanks for the contribution and updating these with the latest versions and deprecated ones. It looks like there is at least 1 new version that has been added since this PR was created, could you update it with the latest versions and then I'd be happy to approve and get this merged in after!
/** | ||
* Version "11.12-rds.20240418" | ||
*/ | ||
public static readonly VER_11_12_RDS_20240418 = PostgresEngineVersion.of('11.12-rds.20240418', '11', { s3Import: true, s3Export: true }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/** Version "5.7.44-rds.20240408". */ | ||
public static readonly VER_5_7_44_RDS_20240408 = MysqlEngineVersion.of('5.7.44-rds.20240408', '5.7'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like there is extended support for version 5.7.44-RDS.20240529 as well now, could we update this PR to include the latest versions?
89a419e
to
185f93d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks @nmussy!
@Mergifyio update |
❌ Mergify doesn't have permission to updateFor security reasons, Mergify can't update this pull request. Try updating locally. |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
@Mergifyio update |
☑️ Nothing to do
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Issue # (if applicable)
None
Reason for this change
Update the CDK RDS engine versions to match the current availability, as well as facilitate automated alerts for updates in the future
Description of changes
@deprecated
TSDoc tagsDescription of how you validated changes
The available versions were compared to live AWS API data. See #29422 for more details.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license