-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cloudformation-diff): format test #30509
Conversation
6843f2f
to
feff0b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Exemption Request Reason: Change has been made to unit-test and not source, hence, change to an integration test file does not make sense:
|
feff0b9
to
c40fdf4
Compare
c40fdf4
to
7448549
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
Unrelated test failures:
|
7448549
to
3670148
Compare
3670148
to
8a04c3d
Compare
- Currently, `yarn build` fails in '@aws-cdk-testing' package with following error because 'Received' string is formatted with `chalk.red` and 'Expected' string is by default formatted with `chalk.green`: ``` ✖ @aws-cdk/cloudformation-diff:test $ cdk-test FAIL test/format.test.ts ● format value can handle partial json strings expect(received).toEqual(expected) // deep equality Expected: "{\"nice\":\"great\",\"partialJson\":\"{\\\"wow\\\": \\\"great\"}" Received: "{\"nice\":\"great\",\"partialJson\":\"{\\\"wow\\\": \\\"great\"}" 6 | test('format value can handle partial json strings', () => { 7 | const output = formatter.formatValue({ nice: 'great', partialJson: '{"wow": "great' }, chalk.red); > 8 | expect(output).toEqual('{\"nice\":\"great\",\"partialJson\":\"{\\\"wow\\\": \\\"great\"}'); | ^ 9 | }); at Object.<anonymous> (test/format.test.ts:8:18) ``` - But as unit-test aims to test equality of strings in terms of content instead of color formatting, hence, it is better to utilise `toMatch` instead of `toEqual`. - Upon retesting, unit-test passed: ``` ✔ @aws-cdk/cloudformation-diff:build [local cache] ```
8a04c3d
to
21eb65d
Compare
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing ✅ A exemption request has been requested. Please wait for a maintainer's review. |
Reason for this change
Currently,
yarn build
fails in '@aws-cdk-testing' package with following error because 'Received' string is formatted withchalk.red
and 'Expected' string is by default formatted withchalk.green
:Description of changes
As unit-test aims to test equality of strings in terms of content instead of color formatting, hence, it is better to utilise
toMatch
instead oftoEqual
.Description of how you validated changes
Upon retesting, unit-test passed:
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license