fix(apigateway): remove timeout upper bound max #30547
Conversation
github-actions
bot
added
the
distinguished-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
| @@ -326,6 +345,7 @@ export abstract class HttpRouteIntegration { | |||
| secureServerName: config.secureServerName, | |||
| parameterMapping: config.parameterMapping, | |||
| credentials: config.credentials, | |||
| timeout: config.timeout, | |||
There was a problem hiding this comment.
This ended up being a "feature" PR as well, the HTTP integration for API Gateway V2 did not implement the timeout prop
There was a problem hiding this comment.
@nmussy the apigatewayv2 is for http and web sockets and the limit is not adjustable for those yet. Only for the apigateway
https://docs.aws.amazon.com/apigateway/latest/developerguide/limits.html
Revert the changes from v2
There was a problem hiding this comment.
This change is only adding the ability to set the timeout prop for the API Gateway V2 HTTP integrations. I'd already added this to the WebSocket integrations previously, see #29566
There was a problem hiding this comment.
@nmussy thanks for making the change
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
nmussy
changed the title
github-actions
bot
added
effort/medium
aws-cdk-automation
added
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
### Issue # (if applicable) Closes aws#30539. ### Reason for this change AWS , see [announcement](https://aws.amazon.com/about-aws/whats-new/2024/06/amazon-api-gateway-integration-timeout-limit-29-seconds/) and [Amazon API Gateway quotas](https://docs.aws.amazon.com/apigateway/latest/developerguide/limits.html) ### Description of changes * Updated exception of `apigateway` `Integration` to only check the `timeout` lower bound * Added exception check of the `timeout` prop to `apigateway-v2` `WebSocketIntegration`, to match the `apigateway` v1 behavior * Implemented the `timeout` property to `apigateway-v2` `HttpIntegration` and its sub-integrations (`HttpAlbIntegration`, `HttpLambdaIntegration`, etc.) * Updated TSDoc ### Description of how you validated changes Updated unit and integration tests ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue # (if applicable) Closes aws#30539. ### Reason for this change AWS , see [announcement](https://aws.amazon.com/about-aws/whats-new/2024/06/amazon-api-gateway-integration-timeout-limit-29-seconds/) and [Amazon API Gateway quotas](https://docs.aws.amazon.com/apigateway/latest/developerguide/limits.html) ### Description of changes * Updated exception of `apigateway` `Integration` to only check the `timeout` lower bound * Added exception check of the `timeout` prop to `apigateway-v2` `WebSocketIntegration`, to match the `apigateway` v1 behavior * Implemented the `timeout` property to `apigateway-v2` `HttpIntegration` and its sub-integrations (`HttpAlbIntegration`, `HttpLambdaIntegration`, etc.) * Updated TSDoc ### Description of how you validated changes Updated unit and integration tests ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Issue # (if applicable)
Closes #30539.
Reason for this change
AWS , see announcement and Amazon API Gateway quotas
Description of changes
apigatewayIntegrationto only check thetimeoutlower boundtimeoutprop toapigateway-v2WebSocketIntegration, to match theapigatewayv1 behaviortimeoutproperty toapigateway-v2HttpIntegrationand its sub-integrations (HttpAlbIntegration,HttpLambdaIntegration, etc.)Description of how you validated changes
Updated unit and integration tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license