Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dynamodb): enable contributor insights for global secondary index #30560

Merged
merged 14 commits into from
Oct 16, 2024
Merged

feat(dynamodb): enable contributor insights for global secondary index #30560

merged 14 commits into from
Oct 16, 2024

Conversation

mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented Jun 16, 2024

Issue # (if applicable)

Closes #15671 .

Reason for this change

To enable contributor insights for a specific global secondary index.

This feature is supported in CFn.

Description of changes

Add contributorInsightsEnabled property to the GlobalSecondaryIndexProps in Table.

In AWS::DynamoDB::GlobalTable GlobalSecondaryIndex, ContributorInsightsSpecification does not exist.

So I didn't change TableV2.

Description of how you validated changes

Add unit test and integ tests.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the star-contributor [Pilot] contributed between 25-49 PRs to the CDK label Jun 16, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team June 16, 2024 09:51
@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Jun 16, 2024
@github-actions github-actions bot mentioned this pull request Jun 17, 2024
Closed
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 21, 2024
@github-actions github-actions bot mentioned this pull request Jul 1, 2024
Closed
@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

badmintoncryer
badmintoncryer suggested changes Sep 21, 2024
View reviewed changes
Copy link
Contributor

@badmintoncryer badmintoncryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! I've added some small comments.

packages/aws-cdk-lib/aws-dynamodb/README.md Outdated Show resolved Hide resolved
...esting/framework-integ/test/aws-dynamodb/test/integ.dynamodb.contirubtor-insights-for-gsi.ts Outdated Show resolved Hide resolved
...esting/framework-integ/test/aws-dynamodb/test/integ.dynamodb.contirubtor-insights-for-gsi.ts Outdated
import { IntegTest } from '@aws-cdk/integ-tests-alpha';

// CDK parameters
const STACK_NAME = 'aws-cdk-dynamodb-contributor-insights-for-gis';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the meaning of gis? If it means global secondary index, it is better to use gsi.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you pointed out, it was a mistake.
I have corrected it.​​​​​​​​​​​​​​​​

...esting/framework-integ/test/aws-dynamodb/test/integ.dynamodb.contirubtor-insights-for-gsi.ts Outdated
partitionKey: GSI_PARTITION_KEY,
});

new IntegTest(app, 'aws-cdk-dynamodb-contributor-insights-for-gis-test', {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just like above, I'm only concerned about gis.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

mazyu36 and others added 4 commits September 22, 2024 09:08
@mazyu36 @badmintoncryer
Update packages/aws-cdk-lib/aws-dynamodb/README.md
1b1678c 
Co-authored-by: Kazuho Cryer-Shinozuka <malaysia.cryer@gmail.com>
@mazyu36 @badmintoncryer
Update packages/@aws-cdk-testing/framework-integ/test/aws-dynamodb/te…
1991ac1 
…st/integ.dynamodb.contirubtor-insights-for-gsi.ts

Co-authored-by: Kazuho Cryer-Shinozuka <malaysia.cryer@gmail.com>
@mazyu36
Merge branch 'main' into dynamodb-cw-insights-for-gsi-15671
68066e1
@mazyu36
update integ test
716c60f
@mazyu36 mazyu36 force-pushed the dynamodb-cw-insights-for-gsi-15671 branch from 072b75e to 716c60f Compare September 22, 2024 01:09
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 22, 2024
@mazyu36
Copy link
Contributor Author

mazyu36 commented Sep 22, 2024

@badmintoncryer
Thank you for the review!
I’ve addressed the comments.

badmintoncryer
badmintoncryer approved these changes Sep 22, 2024
View reviewed changes
Copy link
Contributor

@badmintoncryer badmintoncryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 23, 2024
GavinZZ
GavinZZ approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the consistent contributions!

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 16, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 16, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f86220d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 799b541 into aws:main Oct 16, 2024
12 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 16, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2024
@mazyu36 mazyu36 deleted the dynamodb-cw-insights-for-gsi-15671 branch October 16, 2024 23:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@badmintoncryer badmintoncryer badmintoncryer approved these changes

@GavinZZ GavinZZ GavinZZ approved these changes

Assignees
No one assigned
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(aws-dynamodb): Support ContributorInsightsSpecification for Global Secondary Index
4 participants
@mazyu36 @aws-cdk-automation @GavinZZ @badmintoncryer