Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(s3-notifications): unable to delete the existing S3 event notifications (under feature flag) #30610

Merged
merged 22 commits into from
Jun 26, 2024
Merged

fix(s3-notifications): unable to delete the existing S3 event notifications (under feature flag) #30610

merged 22 commits into from
Jun 26, 2024

Conversation

sarangarav
Copy link
Contributor

@sarangarav sarangarav commented Jun 21, 2024 •
edited
Loading

Issue # (if applicable)

Closes #28915

Reason for this change

Fix to address the issues deleting the existing S3 event notifications and adding new event notifications on top of existing notifications.

Description of changes

We fixed the hashing logic used to identify old vs external S3 event notifications

Description of how you validated changes

Manually tested, integration and unit tested the changes

yes

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/medium Medium work item – several days of effort p1 labels Jun 21, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team June 21, 2024 07:25
aws-cdk-automation
aws-cdk-automation previously requested changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@sarangarav sarangarav changed the title Feature/s3 lambda events notifications fix(s3-notifications): unable to delete the existing S3 event notifications (under feature flag) Jun 21, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 21, 2024 07:28

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@paulhcsun paulhcsun mentioned this pull request Jun 21, 2024
Closed
1 task
sarangarav
sarangarav commented Jun 24, 2024
View reviewed changes
packages/aws-cdk-lib/aws-s3/lib/notifications-resource/notifications-resource-handler.ts
const handlerSourceWithoutComments = handlerSource.replace(/^ *#.*\n?/gm, '');

if (handlerSourceWithoutComments.length > 4096) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline function code can now exceed 4096 bytes. It can support up to 4MB now.

Latest public documentation: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-lambda-function-code.html#cfn-lambda-function-code-zipfile

@github-actions github-actions bot mentioned this pull request Jun 24, 2024
Closed
GavinZZ
GavinZZ previously requested changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@GavinZZ GavinZZ left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some feedbacks

packages/@aws-cdk/custom-resource-handlers/lib/aws-s3/notifications-resource-handler/index.py Show resolved Hide resolved
packages/@aws-cdk/custom-resource-handlers/lib/aws-s3/notifications-resource-handler/index.py Show resolved Hide resolved
packages/aws-cdk-lib/aws-s3/lib/notifications-resource/notifications-resource.ts Outdated Show resolved Hide resolved
@mergify mergify bot dismissed GavinZZ’s stale review June 25, 2024 15:04

Pull request has been modified.

@GavinZZ
Copy link
Contributor

GavinZZ commented Jun 25, 2024

@mergify update

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 25, 2024

update

☑️ Nothing to do

  • #commits-behind>0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]
  • queue-position=-1 [📌 update requirement]

@sarangarav
Copy link
Contributor Author

@mergify update

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 26, 2024

update

☑️ Nothing to do

  • #commits-behind>0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]
  • queue-position=-1 [📌 update requirement]

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 26, 2024
GavinZZ
GavinZZ previously approved these changes Jun 26, 2024
View reviewed changes
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 26, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed GavinZZ’s stale review June 26, 2024 17:47

Pull request has been modified.

GavinZZ
GavinZZ previously approved these changes Jun 26, 2024
View reviewed changes
@mergify mergify bot dismissed GavinZZ’s stale review June 26, 2024 18:34

Pull request has been modified.

@sarangarav sarangarav requested a review from GavinZZ June 26, 2024 19:06
GavinZZ
GavinZZ previously approved these changes Jun 26, 2024
View reviewed changes
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 26, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 26, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 26, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@sarangarav
Copy link
Contributor Author

@Mergifyio refresh

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 26, 2024

refresh

✅ Pull request refreshed

@mergify mergify bot dismissed GavinZZ’s stale review June 26, 2024 20:10

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b586a30
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 26, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b880067 into aws:main Jun 26, 2024
11 checks passed
@GavinZZ GavinZZ mentioned this pull request Jun 27, 2024
Merged
mergify bot pushed a commit that referenced this pull request Jun 27, 2024
@GavinZZ
revert: fix(s3-notifications): unable to delete the existing S3 event…
2869aaa 
… notifications (under feature flag) (#30699)

Reverts #30610 due to Feature flags issues
@github-actions github-actions bot mentioned this pull request Jul 1, 2024
Closed
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GavinZZ GavinZZ GavinZZ approved these changes

@aws-cdk-automation aws-cdk-automation Awaiting requested review from aws-cdk-automation

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/medium Medium work item – several days of effort p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@aws-cdk/aws-s3: Unable to delete the existing S3 event notifications
3 participants
@sarangarav @GavinZZ @aws-cdk-automation