-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(apigatewayv2-integrations): WebSocketMockIntegration
props
#30622
base: main
Are you sure you want to change the base?
Conversation
/** | ||
* A map of Apache Velocity templates that are applied on the request | ||
* payload. | ||
* | ||
* ``` | ||
* { "application/json": "{ \"statusCode\": 200 }" } | ||
* ``` | ||
* | ||
* @default - No request template provided to the integration. | ||
* @see https://docs.aws.amazon.com/apigateway/latest/developerguide/apigateway-websocket-api-mapping-template-reference.html | ||
*/ | ||
readonly requestTemplates?: { [contentType: string]: string }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previous discussion: https://github.com/aws/aws-cdk/pull/29661/files#r1649290535
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Exemption Request: |
989beee
to
24dde44
Compare
* A map of Apache Velocity templates that are applied on the request | ||
* payload. | ||
* | ||
* ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need @example
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit comment: Can you update the integ test file name to be more descriptive? something like websocket-mock-integration
or anything align the line.
I don't think this is a good enough reasoning. Some documentation should have been added when this construct is initially added. Would you please add somethiing to the README to explain the usage and what this is for? Appreciate it. |
Sorry for the late reply, catching up on my notifications. I've added a section in the README for mock integrations.
I understand the possible source for confusion here, but the existing integration files for the response types follow the same naming pattern: $ tree packages/@aws-cdk-testing/framework-integ/test/aws-apigatewayv2-integrations/test/websocket/ -L 1 -I '*/' --gitignore
packages/@aws-cdk-testing/framework-integ/test/aws-apigatewayv2-integrations/test/websocket/
├── integ.aws.ts
├── integ.lambda-connect-disconnect-trigger.ts
├── integ.lambda.ts
├── integ.mock.ts
├── integ.route-response.ts
└── integ.sqs.ts
$ tree packages/@aws-cdk-testing/framework-integ/test/aws-apigatewayv2-integrations/test/http/ -L 1 -I '*/' --gitignore
packages/@aws-cdk-testing/framework-integ/test/aws-apigatewayv2-integrations/test/http/
├── integ.add-subroute-integration.ts
├── integ.alb.ts
├── integ.http-proxy.ts
├── integ.lambda-proxy.ts
├── integ.nlb.ts
├── integ.service-discovery.ts
└── integ.stepfunctions.ts Let me know how you want to handle this, but only renaming |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #30622 +/- ##
=======================================
Coverage 78.67% 78.67%
=======================================
Files 107 107
Lines 7237 7237
Branches 1329 1329
=======================================
Hits 5694 5694
Misses 1357 1357
Partials 186 186
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
None
Reason for this change
Unlike the other integrations,
WebSocketMockIntegration
did not have a props interface, and was missing a few properties. This PR does not include integration responses, they are already being implemented in #29661Description of changes
requestTemplates
andtemplateSelectionExpression
to the newly createdWebSocketMockIntegrationProps
Description of how you validated changes
Unit and integration tests were updated
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license