-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sagemaker): network isolation for a model #30657
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nit, otherwise LGTM.
@msambol Thanks always! I've fixed comments. |
@@ -206,6 +206,17 @@ export interface ModelProps { | |||
* @default true | |||
*/ | |||
readonly allowAllOutbound?: boolean; | |||
|
|||
/** | |||
* Whether to isolate the model container. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could be more descriptive. Maybe combine this with the sentence below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have combined the sentences below. If you have any better suggestions, please let me know!
@@ -206,6 +206,17 @@ export interface ModelProps { | |||
* @default true | |||
*/ | |||
readonly allowAllOutbound?: boolean; | |||
|
|||
/** | |||
* Whether to isolate to enable network isolation for the model container. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I messed up, sorry: Whether to enable network isolation for the model container.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
@mergify update |
❌ Mergify doesn't have permission to updateFor security reasons, Mergify can't update this pull request. Try updating locally. |
@shikha372 Thank you for your approval. Could you please resolve the mergify job problem? |
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
None
Reason for this change
SageMaker model supports for the network isolation function. But Model construct does not support this.
Description of changes
Add
networkIsolation
toModelProps
Description of how you validated changes
Added both unit and integ tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license