Update cdk.template.json to include *.go files. #30667
Conversation
The current behavior for `cdk deploy` is to run `go run cdk.go`. This requires all of the code to be in the named file. Switching it to `go run .` will allow additional files to be included. As the cdk stack becomes more complex, breaking out different props into different files makes the code easier to maintain.
github-actions
bot
added
the
beginning-contributor
jeremyforan
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
|
Your pull request must be based off of a branch in a personal account (not an organization owned account, and not the main branch). You must also have the setting enabled that allows the CDK team to push changes to your branch (this setting is enabled by default for personal accounts, and cannot be enabled for organization owned accounts). The reason for this is that our automation needs to synchronize your branch with our main after it has been approved, and we cannot do that if we cannot push to your branch. |
|
The pull request linter fails with the following errors: PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
|
Your pull request must be based off of a branch in a personal account (not an organization owned account, and not the main branch). You must also have the setting enabled that allows the CDK team to push changes to your branch (this setting is enabled by default for personal accounts, and cannot be enabled for organization owned accounts). The reason for this is that our automation needs to synchronize your branch with our main after it has been approved, and we cannot do that if we cannot push to your branch. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
The default template for cdk Go apps, cdk.json uses
go run %name%.goto initiate the app. The default should be changed to include multiple .go files by default.Reason for this change
cdk.template.json should include all go files in the cdk directory. This is more consistant with most Go projects and allows for the cdk code to be organized into different files by default.
Description of changes
The change is small but, I believe it is what most go developers would expect when running the default project template.
{ "app": "go mod download && go run %name%.go", // ... }to
{ "app": "go mod download && go run .", // ... }Description of how you validated changes
I have run and tested the change in my environment.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license