Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(appconfig): sourcedConfiguration doesn't use retrievalRole #30733

Merged

Conversation

pahud
Copy link
Contributor

@pahud pahud commented Jul 2, 2024

Issue # (if applicable)

Closes #30609

Reason for this change

To refactor the retrievalRole creation logic.

Description of changes

Description of how you validated changes

Unit tests:

  1. configuration with retrievalRole undefined from bucket source should create a new role
  2. configuration with retrievalRole defined should NOT create a new role and should use the passed role for the retrievalRoleArn
  3. configuration with retrievalRole undefined from CodePipeline source should NOT create a new role

Integ test:

  1. update the existing integ test to assert a use case where the retrievalRole is provided.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels Jul 2, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team July 2, 2024 05:25
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 2, 2024
@pahud pahud marked this pull request as ready for review July 2, 2024 05:26
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@pahud pahud changed the title fix(appconfig): SourcedConfiguration doesn't use retrievalRole fix(appconfig): sourcedConfiguration doesn't use retrievalRole Jul 2, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 2, 2024 06:23

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 2, 2024
@Leo10Gama Leo10Gama self-assigned this Jul 24, 2024
Copy link
Member

@Leo10Gama Leo10Gama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor nit about one of the comments, but otherwise LGTM!

Copy link
Member

@Leo10Gama Leo10Gama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

Copy link
Contributor

mergify bot commented Jul 25, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 25, 2024
Copy link
Contributor

mergify bot commented Jul 25, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Jul 25, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 9d79c51 into aws:main Jul 25, 2024
9 checks passed
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-appconfig: SourcedConfiguration doesn't use retrievalRole
3 participants