Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add condition to bootstrap file publish role #30823

Merged
merged 5 commits into from
Jul 12, 2024
Merged

chore: add condition to bootstrap file publish role #30823

merged 5 commits into from
Jul 12, 2024

Conversation

scanlonp
Copy link
Contributor

@scanlonp scanlonp commented Jul 10, 2024 •
edited
Loading

Adds a condition to restrict s3 permissions on the file publish role.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Jul 10, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team July 10, 2024 23:01
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 10, 2024
@scanlonp
Copy link
Contributor Author

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 10, 2024

update

✅ Branch has been successfully updated

@mergify mergify bot temporarily deployed to test-pipeline July 10, 2024 23:02 Inactive
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 10, 2024
@aws-cdk-automation
Copy link
Collaborator

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@TheRealAmazonKendra
Copy link
Contributor

Submitted to CLI pipeline

@TheRealAmazonKendra TheRealAmazonKendra added the pr/do-not-merge This PR should not be merged at this time. label Jul 11, 2024
TheRealAmazonKendra
TheRealAmazonKendra approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right. Approving pending test pipeline success. I've added the do-not-merge label in the meantime. Feel free to remove once we've verified all the test results.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 11, 2024
@scanlonp
Copy link
Contributor Author

Succeeding in the test pipeline.

@scanlonp scanlonp added pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested and removed pr/do-not-merge This PR should not be merged at this time. labels Jul 11, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 11, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot had a problem deploying to test-pipeline July 11, 2024 23:33 Failure
@scanlonp
Copy link
Contributor Author

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 12, 2024

update

☑️ Nothing to do

  • #commits-behind>0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]
  • queue-position=-1 [📌 update requirement]

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 87371d8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 12, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 5ef3be5 into aws:main Jul 12, 2024
8 of 9 checks passed
@github-actions github-actions bot mentioned this pull request Jul 15, 2024
Closed
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TheRealAmazonKendra TheRealAmazonKendra TheRealAmazonKendra approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scanlonp @aws-cdk-automation @TheRealAmazonKendra