-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cognito): add tags
property for user pool
#31108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! I've added 2 minor comments.
packages/@aws-cdk-testing/framework-integ/test/aws-cognito/test/integ.user-pool-tags.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Kazuho Cryer-Shinozuka <malaysia.cryer@gmail.com>
…t/integ.user-pool-tags.ts Co-authored-by: Kazuho Cryer-Shinozuka <malaysia.cryer@gmail.com>
@badmintoncryer Thank you for the suggestion, I've just committed them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In L2 construct, we don't directly provide tags
property even though it's supported in the relevant L1 construct.
The typical way of adding tag is through Tags.of(this).add
. Does this method work for you?
Thank you, the |
As a side note, if you use If this is not the ideal solution you could also do Let’s close this PR as I believe this change is not needed anymore. |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Reason for this change
The userPoolTags property existed in the L1 construct but was not present in the L2 construct
Description of changes
Add the tags property for UserPool
Description of how you validated changes
Added a unit test and an integration test.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license