Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(synthetics): added syn-python-selenium-4.0 as supported runtime #31223

Conversation

ashishdhingra
Copy link
Contributor

Issue # (if applicable)

Closes #31218.

Reason for this change

Description of changes

Added syn-python-selenium-4.0 as supported runtime.

Description of how you validated changes

N/A

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 26, 2024
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels Aug 26, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team August 26, 2024 17:12
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: beb8ea3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 26, 2024
@mazyu36
Copy link
Contributor

mazyu36 commented Aug 27, 2024

@ashishdhingra
Hi.
I'm sorry for the abrupt message. I have already created a similar PR(#31101) and have had a Community Review conducted.
Could you please advise which PR we should keep? (Either one is fine.)

@xazhao
Copy link
Contributor

xazhao commented Aug 27, 2024

Thanks for the contribution. Since PR(#31101) includes unit test/integration test, I will keep PR(#31101) and close this PR.

@xazhao xazhao closed this Aug 27, 2024
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2024
@ashishdhingra ashishdhingra deleted the user/ashdhin/synthetics-add-syn-python-selenium-4.0 branch August 27, 2024 20:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

synthetics: synthetics python selenium 4.0 missing in Runtime options
4 participants