-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(appmesh): multiple virtual node listeners now possible #32166
base: main
Are you sure you want to change the base?
Conversation
The issue at aws/aws-app-mesh-roadmap#120 is now completed, so I imagine multiple virtual node listeners is now possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Exemption Request Maybe I should have re-based instead of hitting 'Update branch' and that's throwing things off? |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Hi @benmccallum, when you say you imagine multiple virtual node listeners is now possible, have you confirmed that it works? If not, one of us should do a sanity check before approving this PR. |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
The issue at aws/aws-app-mesh-roadmap#120 is now completed, so I imagine multiple virtual node listeners is now possible.
Issue # (if applicable)
N/A
Reason for this change
Comment on method doesn't reflect reality.
Description of changes
Updates doc comment on addListener to reflect current reality.
Description of how you validated changes
N/A
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license