Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(appmesh): multiple virtual node listeners now possible #32166

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

benmccallum
Copy link

The issue at aws/aws-app-mesh-roadmap#120 is now completed, so I imagine multiple virtual node listeners is now possible.

Issue # (if applicable)

N/A

Reason for this change

Comment on method doesn't reflect reality.

Description of changes

Updates doc comment on addListener to reflect current reality.

Description of how you validated changes

N/A

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

The issue at aws/aws-app-mesh-roadmap#120 is now completed, so I imagine multiple virtual node listeners is now possible.
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Nov 18, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team November 18, 2024 01:14
@github-actions github-actions bot added the p2 label Nov 18, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@benmccallum
Copy link
Author

benmccallum commented Nov 18, 2024

Exemption Request

Maybe I should have re-based instead of hitting 'Update branch' and that's throwing things off?

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Nov 18, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: cdf7ed5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 18, 2024
@kaizencc
Copy link
Contributor

Hi @benmccallum, when you say you imagine multiple virtual node listeners is now possible, have you confirmed that it works? If not, one of us should do a sanity check before approving this PR.

@kaizencc kaizencc changed the title docs: Update virtual-node.ts method doc docs(appmesh): multiple virtual node listeners now possible Nov 18, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 18, 2024 15:24

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

gracelu0
gracelu0 previously approved these changes Nov 20, 2024
Copy link
Contributor

mergify bot commented Nov 20, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@gracelu0 gracelu0 dismissed their stale review November 20, 2024 19:49

missed Kaizen's comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants