Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): update tests for future monorepo #32185

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Nov 19, 2024

A number of our tests depend on the version of the cloud-assembly-schema, and some of our tests use aws-cdk-lib to generate Cloud Assemblies which has its own copy of cloud-assembly-schema built in.

Because cloud-assembly-schema currently takes its schema version from its package.json version, and because the version of cloud-assembly-schema/package.json will be 0.0.0 once it has been moved into our new monorepo, these tests need to be changed to deal with this situation.

The solution we're currently taking is to rewrite manifest.json and change the version in there to a different one.

This PR also renames expect(...).toBeCalledWith() to expect(...).toHaveBeenCalledWith() because the jest linter requires is.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@rix0rrr rix0rrr changed the title chore: update tests for future monorepo chore(cli): update tests for future monorepo Nov 19, 2024
@github-actions github-actions bot added the p2 label Nov 19, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team November 19, 2024 13:33
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.18%. Comparing base (3e7ba32) to head (4cb97c7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32185   +/-   ##
=======================================
  Coverage   77.18%   77.18%           
=======================================
  Files         105      105           
  Lines        7161     7161           
  Branches     1312     1312           
=======================================
  Hits         5527     5527           
  Misses       1454     1454           
  Partials      180      180           
Flag Coverage Δ
suite.unit 77.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 77.18% <ø> (ø)
---- 🚨 Try these New Features:

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 19, 2024
Copy link
Contributor

mergify bot commented Nov 19, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 19, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 4cb97c7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 49b5afd into main Nov 19, 2024
19 of 20 checks passed
Copy link
Contributor

mergify bot commented Nov 19, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the huijbers/fix-tests-cloudassembly branch November 19, 2024 17:03
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants