-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cli): update tests for future monorepo #32185
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32185 +/- ##
=======================================
Coverage 77.18% 77.18%
=======================================
Files 105 105
Lines 7161 7161
Branches 1312 1312
=======================================
Hits 5527 5527
Misses 1454 1454
Partials 180 180
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
A number of our tests depend on the version of the
cloud-assembly-schema
, and some of our tests useaws-cdk-lib
to generate Cloud Assemblies which has its own copy ofcloud-assembly-schema
built in.Because
cloud-assembly-schema
currently takes its schema version from itspackage.json
version, and because the version ofcloud-assembly-schema/package.json
will be0.0.0
once it has been moved into our new monorepo, these tests need to be changed to deal with this situation.The solution we're currently taking is to rewrite
manifest.json
and change theversion
in there to a different one.This PR also renames
expect(...).toBeCalledWith()
toexpect(...).toHaveBeenCalledWith()
because the jest linter requires is.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license