Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rds): support zero ACU for Aurora Serverless V2 #32231

Merged
merged 4 commits into from
Nov 23, 2024

Conversation

mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented Nov 21, 2024

Issue # (if applicable)

Closes #32234.

Reason for this change

Amazon Aurora Serverless v2 supports scaling to zero capacity.

Ref: https://aws.amazon.com/about-aws/whats-new/2024/11/amazon-aurora-serverless-v2-scaling-zero-capacity/

Description of changes

"Updated validation to permit zero as a value for serverlessV2MinCapacity.

Description of how you validated changes

Fix unit tests and add an integ test.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team November 21, 2024 11:05
@github-actions github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Nov 21, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@mazyu36 mazyu36 marked this pull request as ready for review November 21, 2024 11:14
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 21, 2024 11:16

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.17%. Comparing base (74086a0) to head (7b4755b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32231   +/-   ##
=======================================
  Coverage   77.17%   77.17%           
=======================================
  Files         105      105           
  Lines        7169     7169           
  Branches     1315     1315           
=======================================
  Hits         5533     5533           
  Misses       1455     1455           
  Partials      181      181           
Flag Coverage Δ
suite.unit 77.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 77.17% <ø> (ø)
---- 🚨 Try these New Features:

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 21, 2024
@tehnrd
Copy link

tehnrd commented Nov 21, 2024

Issue I created before seeing the PR

#32234

@github-actions github-actions bot added the feature-request A feature should be added or improved. label Nov 21, 2024
@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Nov 21, 2024
@AbrahamOEd
Copy link

Should there be validation for the engine type? It's only available on the following

Aurora PostgreSQL 13.15+, 14.12+, 15.7+, and 16.3+, and Aurora MySQL 3.08+.

@mazyu36
Copy link
Contributor Author

mazyu36 commented Nov 22, 2024

@AbrahamOEd
Thank you for your comment. I'd like to leave this to the maintainer's discretion.
Beyond this specific case, validation based on engine versions is generally not implemented.
If we add validation, it would likely require modifications every time a new version is added.

GavinZZ
GavinZZ previously approved these changes Nov 22, 2024
Copy link
Contributor

mergify bot commented Nov 22, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 22, 2024
@GavinZZ GavinZZ dismissed their stale review November 22, 2024 21:04

Dismissing to investigate the comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 22, 2024
GavinZZ
GavinZZ previously approved these changes Nov 22, 2024
Copy link
Contributor

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve it. CloudFormation will validate it and since this seems to be something that could be changing fairly frequently, I think it makes sense to not validate it on CDK side.

Copy link
Contributor

mergify bot commented Nov 22, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mazyu36
Copy link
Contributor Author

mazyu36 commented Nov 22, 2024

@Mergifyio update

Copy link
Contributor

mergify bot commented Nov 22, 2024

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/codecov.yml without workflows permission

@mergify mergify bot dismissed GavinZZ’s stale review November 23, 2024 00:18

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7b4755b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mazyu36
Copy link
Contributor Author

mazyu36 commented Nov 23, 2024

@GavinZZ
Thank you as always!
Mergify encountered an error, so I merged main.
Could you please approve again?

@mazyu36 mazyu36 requested a review from GavinZZ November 23, 2024 01:01
Copy link
Contributor

mergify bot commented Nov 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit d1b07d9 into aws:main Nov 23, 2024
20 checks passed
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2024
@mazyu36 mazyu36 deleted the aurora-acu-0 branch November 23, 2024 01:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK feature-request A feature should be added or improved. p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DatabaseCluster: serverlessV2MinCapacity should allow scaling to 0
6 participants