Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop requirement from ~> 1.22.3 to ~> 1.23.0 #1266

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 26, 2021

Updates the requirements on rubocop to permit the latest version.

Release notes

Sourced from rubocop's releases.

RuboCop 1.23

New features

Bug fixes

  • #10203: Fix Style/FormatStringToken to respect IgnoredMethods with nested structures. (@​tejasbubane)
  • #10242: Fix last_column value for JSONFormatter. (@​koic)
  • #10229: Fix a false positive for Style/StringLiterals when EnforcedStyle: double_quotes and using single quoted string with backslash. (@​koic)
  • #10174: Fix inherit_from_remote should follow remote includes path starting with ./. (@​hirasawayuki)
  • #10234: Fix an error for Style/Documentation when using a cbase class. (@​koic)
  • #10227: Fix a false positive for Style/ParenthesesAroundCondition when parentheses in multiple expressions separated by semicolon. (@​koic)
  • #10230: Fix a false positive for Lint/AmbiguousRange when a range is composed of all literals except basic literals. (@​koic)

Changes

  • #10221: Update Naming::FileName to recognize Structs as classes that satisfy the ExpectMatchingDefinition requirement. (@​dvandersluis)
  • #10220: Update Naming/FileName to make CheckDefinitionPathHierarchy roots configurable. (@​grosser)
  • #10199: Change AllowAdjacentOneLineDefs config parameter of Layout/EmptyLineBetweenDefs to true by default . (@​koic)
  • #10236: Make Lint/NumberConversion aware of to_r. (@​koic)
Changelog

Sourced from rubocop's changelog.

1.23.0 (2021-11-15)

New features

Bug fixes

  • #10203: Fix Style/FormatStringToken to respect IgnoredMethods with nested structures. ([@​tejasbubane][])
  • #10242: Fix last_column value for JSONFormatter. ([@​koic][])
  • #10229: Fix a false positive for Style/StringLiterals when EnforcedStyle: double_quotes and using single quoted string with backslash. ([@​koic][])
  • #10174: Fix inherit_from_remote should follow remote includes path starting with ./. ([@​hirasawayuki][])
  • #10234: Fix an error for Style/Documentation when using a cbase class. ([@​koic][])
  • #10227: Fix a false positive for Style/ParenthesesAroundCondition when parentheses in multiple expressions separated by semicolon. ([@​koic][])
  • #10230: Fix a false positive for Lint/AmbiguousRange when a range is composed of all literals except basic literals. ([@​koic][])

Changes

  • #10221: Update Naming::FileName to recognize Structs as classes that satisfy the ExpectMatchingDefinition requirement. ([@​dvandersluis][])
  • #10220: Update Naming/FileName to make CheckDefinitionPathHierarchy roots configurable. ([@​grosser][])
  • #10199: Change AllowAdjacentOneLineDefs config parameter of Layout/EmptyLineBetweenDefs to true by default . ([@​koic][])
  • #10236: Make Lint/NumberConversion aware of to_r. ([@​koic][])

1.22.3 (2021-10-27)

Bug fixes

  • #10166: Fix a false positive for Style/StringLiterals when using some meta characters (e.g. '\s', '\z') with EnforcedStyle: double_quotes. ([@​koic][])
  • #10216: Fix an incorrect autocorrect for Style/SelectByRegexp when using lvar =~ blockvar in a block. ([@​koic][])
  • #10207: Fix false positive in Layout/DotPosition when the selector is on the same line as the closing bracket of the receiver. ([@​mvz][])

Changes

  • #10209: Make Lint/DeprecatedConstants aware of Net::HTTPServerException. ([@​koic][])

1.22.2 (2021-10-22)

Bug fixes

  • #10165: Fix Layout/DotPosition false positives when the selector and receiver are on the same line. ([@​dvandersluis][])
  • #10171: Fix Style/HashTransformKeys and Style/HashTransformValues incorrect auto-correction when inside block body. ([@​franzliedke][])
  • #10180: Fix an error for Style/SelectByRegexp when using match? without a receiver. ([@​koic][])
  • #10193: Fix an error for Layout/EmptyLinesAroundExceptionHandlingKeywords when begin and rescue are on the same line. ([@​koic][])
  • #10185: Fix a false positive for Lint/AmbiguousRange when using self in a range literal. ([@​koic][])
  • #10200: Fix an error when inspecting a directory named *. ([@​koic][])
  • #10149: Fix Bundler/GemComment where it would not detect an offense in some cases when OnlyFor is set to restrictive_version_specifiers. ([@​Drowze][])

Changes

... (truncated)

Commits
  • 2738602 Cut 1.23
  • 95e851c Update Changelog
  • 5780761 Add new Gemspec/RequireMFA cop.
  • 12e0993 Refactor shared gemspec matcher into a mixin.
  • bdb92d6 Merge pull request #10246 from koic/tweak_offense_range_for_layout_space_in_l...
  • e152d25 Merge pull request #10224 from grosser/grosser/paths
  • 9cb95c9 [Fix #10220] Naming/FileName: make CheckDefinitionPathHierarchy roots configu...
  • dc7ffcb Tweak offense range for Layout/SpaceInLambdaLiteral
  • 1502503 Add rubocop-graphql as a third-party extension in the docs
  • c7c498f Add rubocop-graphql to suggested extensions
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot requested a review from a team as a code owner November 26, 2021 19:07
@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Nov 26, 2021
@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-tw-1.23.0 branch from 04b8f85 to e63343a Compare December 23, 2021 15:54
@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-tw-1.23.0 branch 2 times, most recently from d53fc9c to 90489a0 Compare July 6, 2022 12:54
@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-tw-1.23.0 branch from 90489a0 to 21d3de2 Compare July 15, 2022 07:27
@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-tw-1.23.0 branch from 21d3de2 to 1b21b78 Compare September 20, 2022 15:26
@dependabot dependabot bot requested a review from a team as a code owner September 20, 2022 15:26
Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.22.3...v1.23.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-tw-1.23.0 branch from 1b21b78 to ff61626 Compare April 14, 2023 12:23
@dependabot dependabot bot requested a review from a team as a code owner April 14, 2023 12:23
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #1266 (ff61626) into develop (e3e5c6a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1266   +/-   ##
========================================
  Coverage    69.42%   69.42%           
========================================
  Files           12       12           
  Lines         1766     1766           
========================================
  Hits          1226     1226           
  Misses         540      540           
Flag Coverage Δ
unittests 69.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants