Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tools] Add tool to update third party cookbooks. #1476

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

gmarciani
Copy link
Contributor

Description of changes

Add tool to update third party cookbooks.

Example of usage:

./update-cookbook-dependency.sh apt 7.4.2
[INFO] Updating dependency: apt 7.4.2...
[INFO] Detecting current version of apt
[INFO] Current version of apt is: 7.4.0
[INFO] Downloading apt 7.4.2 from Chef Marketplace
--2022-07-05 16:56:34--  https://github.com/sous-chefs/apt/archive/refs/tags/7.4.2.tar.gz
Resolving github.com (github.com)... 140.82.121.3
Connecting to github.com (github.com)|140.82.121.3|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://codeload.github.com/sous-chefs/apt/tar.gz/refs/tags/7.4.2 [following]
--2022-07-05 16:56:35--  https://codeload.github.com/sous-chefs/apt/tar.gz/refs/tags/7.4.2
Resolving codeload.github.com (codeload.github.com)... 140.82.121.9
Connecting to codeload.github.com (codeload.github.com)|140.82.121.9|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [application/x-gzip]
Saving to: ‘/Users/mgiacomo/workplace/aws-parallelcluster-cookbook/third-party/apt-7.4.2.tar.gz’

/Users/mgiacomo/workplace/aws-parallelcluster-cookbook/third-party/apt-7.4.2.     [ <=>                                                                                                                                                                                              ]  30,05K  --.-KB/s    in 0,05s   

2022-07-05 16:56:35 (595 KB/s) - ‘/Users/mgiacomo/workplace/aws-parallelcluster-cookbook/third-party/apt-7.4.2.tar.gz’ saved [30774]

[INFO] Updating metadata: /Users/mgiacomo/workplace/aws-parallelcluster-cookbook/metadata.rb
[INFO] Updating metadata: /Users/mgiacomo/workplace/aws-parallelcluster-cookbook/cookbooks/aws-parallelcluster-awsbatch/metadata.rb
[INFO] Updating metadata: /Users/mgiacomo/workplace/aws-parallelcluster-cookbook/cookbooks/aws-parallelcluster-config/metadata.rb
[INFO] Updating metadata: /Users/mgiacomo/workplace/aws-parallelcluster-cookbook/cookbooks/aws-parallelcluster-install/metadata.rb
[INFO] Updating metadata: /Users/mgiacomo/workplace/aws-parallelcluster-cookbook/cookbooks/aws-parallelcluster-scheduler-plugin/metadata.rb
[INFO] Updating metadata: /Users/mgiacomo/workplace/aws-parallelcluster-cookbook/cookbooks/aws-parallelcluster-slurm/metadata.rb
[INFO] Updating metadata: /Users/mgiacomo/workplace/aws-parallelcluster-cookbook/cookbooks/aws-parallelcluster-scheduler-plugin/metadata.rb
[INFO] Updating metadata: /Users/mgiacomo/workplace/aws-parallelcluster-cookbook/cookbooks/aws-parallelcluster-test/metadata.rb
[INFO] Updating Berksfile: /Users/mgiacomo/workplace/aws-parallelcluster-cookbook/Berksfile
[INFO] Removing previous version of apt 7.4.0
[INFO] Dependency updated: apt 7.4.2

Tests

Script has been used to upgrade dependencies for 3.2.0

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Giacomo Marciani mgiacomo@amazon.com

Signed-off-by: Giacomo Marciani <mgiacomo@amazon.com>
@gmarciani gmarciani force-pushed the wip/mgiacomo/develop/utilities/update-cookbook-deps branch from b6c0474 to 446d28e Compare July 5, 2022 17:17
@enrico-usai enrico-usai requested a review from a team as a code owner May 4, 2023 09:58

METADATA_FILES=(
"${PARALLEL_CLUSTER_COOKBOOK_DIR}/metadata.rb"
"${PARALLEL_CLUSTER_COOKBOOK_DIR}/cookbooks/aws-parallelcluster-awsbatch/metadata.rb"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing common cookbook

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #1476 (0a22258) into develop (3f75f2c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1476   +/-   ##
========================================
  Coverage    70.01%   70.01%           
========================================
  Files           13       13           
  Lines         1834     1834           
========================================
  Hits          1284     1284           
  Misses         550      550           
Flag Coverage Δ
unittests 70.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@gmarciani
Copy link
Contributor Author

This PR is still valid as of today. We wil resume the work done here soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants