Add EFS access point support (aws-parallelcluster#2337) #2779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Heinen <t.heinen@reply.de>
gmarciani
requested changes
Jul 22, 2024
cookbooks/aws-parallelcluster-environment/recipes/config/efs.rb
Outdated
Show resolved
Hide resolved
|
|
||
| # Path needs to be fully qualified, for example "shared/temp" becomes "/shared/temp" | ||
| efs_shared_dir = "/#{efs_shared_dir}" unless efs_shared_dir.start_with?('/') | ||
|
|
||
| # See reference of mount options: https://docs.aws.amazon.com/efs/latest/ug/automount-with-efs-mount-helper.html | ||
| mount_options = "_netdev,noresvport" | ||
| if efs_encryption_in_transit == "true" | ||
| if efs_accesspoint_id |
There was a problem hiding this comment.
This should be covered in the unit test.
Example: https://github.com/aws/aws-parallelcluster-cookbook/blob/develop/cookbooks/aws-parallelcluster-environment/spec/unit/resources/efs_spec.rb#L295
cookbooks/aws-parallelcluster-environment/resources/efs/partial/_mount_umount.rb
Outdated
Show resolved
Hide resolved
cookbooks/aws-parallelcluster-environment/attributes/environment.rb
Outdated
Show resolved
Hide resolved
|
Hi @thheinen, Made a first round of review and unblocked PR checks. |
gmarciani
requested changes
Jul 22, 2024
cookbooks/aws-parallelcluster-environment/attributes/environment.rb
Outdated
Show resolved
Hide resolved
Signed-off-by: Thomas Heinen <t.heinen@reply.de>
dreambeyondorange
requested changes
Aug 9, 2024
Comment on lines
-1
to
-8
| aws-parallelcluster-cookbook CHANGELOG | ||
| ====================================== | ||
|
|
||
| This file is used to list changes made in each version of the AWS ParallelCluster cookbook. | ||
|
|
||
| 3.11.0 | ||
| ------ | ||
|
|
There was a problem hiding this comment.
Why was this whole file changed?
|
LGTM! It can be merged when the CLI changes are ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add support to specify EFS access points per issue aws/aws-parallelcluster#2337
Tests
Tested mounting EFS with and without accesspoints from an aws-parallelcluster cluster.
More tests to be done but opening a draft PR for discussion and early feedback
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.