Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add error handling for provided runtime layer building #5733

Merged
merged 7 commits into from
Aug 10, 2023

Conversation

mildaniel
Copy link
Contributor

Which issue(s) does this change fix?

#5586

Why is this change necessary?

Don't crash SAM CLI if CompatibleRuntimes is none and explain the issue to users.

How does it address the issue?

Adds additional error handling to gracefully exit and provide failure details to users.

What side effects does this change have?

N/A

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mildaniel mildaniel requested a review from a team as a code owner August 9, 2023 18:20
@github-actions github-actions bot added area/build sam build command pr/internal labels Aug 9, 2023
Copy link
Contributor

@moelasmar moelasmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good to me, can you just update this class

class TestBuildCommand_LayerBuilds(BuildIntegBase):
, and add a new test case to testing makefile layers without CompatibleRuntimes

@mildaniel mildaniel added this pull request to the merge queue Aug 10, 2023
Merged via the queue into aws:develop with commit 19a0cae Aug 10, 2023
76 checks passed
@mildaniel mildaniel deleted the fix-no-compatible-runtimes branch August 10, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build sam build command pr/internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants