Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Terraform Custom Plan File Support #5734

Merged
merged 7 commits into from
Aug 10, 2023

Conversation

mildaniel
Copy link
Contributor

Which issue(s) does this change fix?

N/A

Why is this change necessary?

Support users who use Terraform Cloud by allowing them to pass a custom plan file instead of generating one.

How does it address the issue?

Creates a new command line option for passing a plan file and using that one in the Terraform hook instead of generating a plan file.

What side effects does this change have?

N/A

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added area/build sam build command area/local/invoke sam local invoke command pr/internal labels Aug 9, 2023
@mildaniel mildaniel marked this pull request as ready for review August 9, 2023 22:05
@mildaniel mildaniel requested a review from a team as a code owner August 9, 2023 22:05
samcli/commands/_utils/options.py Outdated Show resolved Hide resolved
samcli/commands/build/core/options.py Outdated Show resolved Hide resolved
@lucashuy
Copy link
Contributor

lucashuy commented Aug 9, 2023

Should we consider adding a check if hook name is provided, if it isn't then we raise a bad click option exception?

@mildaniel mildaniel added this pull request to the merge queue Aug 10, 2023
Merged via the queue into aws:develop with commit 1518e7f Aug 10, 2023
76 checks passed
@mildaniel mildaniel deleted the terraform-cloud-support branch August 10, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build sam build command area/local/invoke sam local invoke command pr/internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants