-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: adding integration testing to test supporting terraform nested directories project structure #5748
test: adding integration testing to test supporting terraform nested directories project structure #5748
Conversation
…ng in root module directory
…directories project structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, left a minor comment but it's non blocking
("aws_lambda_function.function1", "hello world 1"), | ||
("module.function2.aws_lambda_function.this", "hello world 1"), | ||
("module.function7.aws_lambda_function.this[0]", "hello world 1"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the plan to add more functions? Just poking at this since they all have the same output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am testing lambda functions/layers defined in different ways - in the root module - in external modules - using 3rd party modules, and all of them are referring to the same source code, so the output is the same for all of them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and source code, and custom modules are defined in a different directory structure outside the root module directory
add integration testing for new feature added in this PR
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make pr
passesmake update-reproducible-reqs
if dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.