Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: adding integration testing to test supporting terraform nested directories project structure #5748

Merged

Conversation

moelasmar
Copy link
Contributor

add integration testing for new feature added in this PR

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added area/build sam build command area/schema JSON schema file pr/internal labels Aug 10, 2023
@moelasmar moelasmar marked this pull request as ready for review August 10, 2023 22:09
@moelasmar moelasmar requested a review from a team as a code owner August 10, 2023 22:09
Copy link
Contributor

@lucashuy lucashuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, left a minor comment but it's non blocking

Comment on lines +419 to +421
("aws_lambda_function.function1", "hello world 1"),
("module.function2.aws_lambda_function.this", "hello world 1"),
("module.function7.aws_lambda_function.this[0]", "hello world 1"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the plan to add more functions? Just poking at this since they all have the same output

Copy link
Contributor Author

@moelasmar moelasmar Aug 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am testing lambda functions/layers defined in different ways - in the root module - in external modules - using 3rd party modules, and all of them are referring to the same source code, so the output is the same for all of them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and source code, and custom modules are defined in a different directory structure outside the root module directory

@moelasmar moelasmar added this pull request to the merge queue Aug 10, 2023
Merged via the queue into aws:develop with commit 6fd3389 Aug 11, 2023
76 checks passed
@moelasmar moelasmar deleted the develop_nested_directories_integration_testing branch August 11, 2023 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build sam build command area/schema JSON schema file pr/internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants