-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add --save-params
option
#5808
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/package
sam package command
area/deploy
sam deploy command
area/validate
sam validate command
area/init
sam init
area/logs
sam logs command
area/build
sam build command
area/publish
sam publish command
area/local/invoke
sam local invoke command
area/pipeline
area/delete
area/sync
sam sync command
area/traces
area/schema
JSON schema file
pr/external
stage/needs-triage
Automatically applied to new issues and PRs, indicating they haven't been looked at.
labels
Aug 21, 2023
lucashuy
added
pr/internal
and removed
pr/external
stage/needs-triage
Automatically applied to new issues and PRs, indicating they haven't been looked at.
labels
Aug 21, 2023
lucashuy
reviewed
Aug 21, 2023
lucashuy
reviewed
Aug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes! Just two minor comments, but the other changes look good to me
lucashuy
approved these changes
Aug 22, 2023
hnnasit
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left small comments but overall looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/build
sam build command
area/delete
area/deploy
sam deploy command
area/init
sam init
area/local/invoke
sam local invoke command
area/logs
sam logs command
area/package
sam package command
area/pipeline
area/publish
sam publish command
area/schema
JSON schema file
area/sync
sam sync command
area/traces
area/validate
sam validate command
pr/internal
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this change necessary?
With the addition of this parameter, it will be possible for users to save parameters to the config file directly from the terminal as they are passed in. This will simplify the process of setting up configurations, since the file doesn't have to be open.
How does it address the issue?
The
--save-params
option has been added to most of the existing commands. With it, when run, any command passed in via the terminal will be saved to the provided config file.What side effects does this change have?
Most commands now have an additional parameter, and an additional decorator on their
cli()
methods.Mandatory Checklist
PRs will only be reviewed after checklist is complete
make pr
passesmake update-reproducible-reqs
if dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.