Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove str type constrain in Fn:FindInMap to avoid the issue of looking up number in a map #7305

Closed
wants to merge 2 commits into from

Conversation

dkphm
Copy link
Contributor

@dkphm dkphm commented Aug 2, 2024

Remove the restriction on str type when Fn:FindInMap is called.

Which issue(s) does this change fix?

#6975

Why is this change necessary?

To allow customer to start lambda locally.

How does it address the issue?

Customer cannot start lambda locally if the yaml template include a function Fn:FindInMap inside a timeout property.

What side effects does this change have?

N/A

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dkphm dkphm requested a review from a team as a code owner August 2, 2024 17:57
@github-actions github-actions bot added pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Aug 2, 2024
@dkphm dkphm closed this Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant