Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix a canary failure due to an updated error messages from boto lib #7419

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

dkphm
Copy link
Contributor

@dkphm dkphm commented Aug 28, 2024

Which issue(s) does this change fix?

Why is this change necessary?

Error message changed from boto3 and we need to adapt the integ tests accordingly.

How does it address the issue?

What side effects does this change have?

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dkphm dkphm requested a review from a team as a code owner August 28, 2024 16:56
@github-actions github-actions bot added pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Aug 28, 2024
@dkphm dkphm added pr/internal and removed pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Aug 28, 2024
@dkphm dkphm enabled auto-merge August 28, 2024 17:47
@dkphm dkphm added this pull request to the merge queue Aug 28, 2024
Merged via the queue into aws:develop with commit 7c624ef Aug 28, 2024
57 checks passed
@dkphm dkphm deleted the fix-integ-test branch August 28, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants