-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding dotnet
build method that is version agnostic
#7495
Conversation
Thanks for adding the flag for a generic |
Thanks.
|
Looks like the test failure is unrelated: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the contribution!
dotnet
build method that is version agnosticdotnet
build method that is version agnostic
Tested with
SAM_CLI_DEV=1 pytest tests/integration -k "test_dotnet_al2_2_provided_al2"
1 passed, 2102 deselected in 17.34s
Which issue(s) does this change fix?
#7463
Why is this change necessary?
See issue
How does it address the issue?
Adds dotnet build method
What side effects does this change have?
dotnet7 build method is now unnecessary, but kept for backwards compatibility.
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make pr
passesmake update-reproducible-reqs
if dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.