Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AWS_LAMBDA_INITIALIZATION_TYPE env var #7533

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Add AWS_LAMBDA_INITIALIZATION_TYPE env var #7533

merged 2 commits into from
Oct 4, 2024

Conversation

leandrodamascena
Copy link
Contributor

@leandrodamascena leandrodamascena commented Oct 3, 2024 •
edited
Loading

Which issue(s) does this change fix?

fixes #7532

Why is this change necessary?

According to the official AWS documentation there is a environment variable named AWS_LAMBDA_INITIALIZATION_TYPE that can contains following values: on-demand, provisioned-concurrency, or snap-start. Since SAM is intended to emulate Lambda in local environment, so, its good if SAM can include this env var with the default value on-demand, for example.

How does it address the issue?

Adding the correspondent env var.

What side effects does this change have?

I don't see any.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@leandrodamascena leandrodamascena requested a review from a team as a code owner October 3, 2024 21:50
@github-actions github-actions bot added area/local/start-api sam local start-api command area/local/invoke sam local invoke command area/local/start-invoke pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Oct 3, 2024
hawflau
hawflau approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@hawflau hawflau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution!

@hawflau hawflau added this pull request to the merge queue Oct 4, 2024
Merged via the queue into aws:develop with commit 4656a42 Oct 4, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hnnasit hnnasit hnnasit approved these changes

@hawflau hawflau hawflau approved these changes

@jysheng123 jysheng123 Awaiting requested review from jysheng123 jysheng123 is a code owner automatically assigned from aws/serverless-application-experience-sbt

Assignees
No one assigned
Labels
area/local/invoke sam local invoke command area/local/start-api sam local start-api command area/local/start-invoke pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: Add AWS_LAMBDA_INITIALIZATION_TYPE environment variable
3 participants
@leandrodamascena @hawflau @hnnasit