Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove py313 install steps from the Windows Al2023 based AppVeyor project #7703

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

hnnasit
Copy link
Contributor

@hnnasit hnnasit commented Nov 18, 2024

Why is this change necessary?

Python3.13 and nodejs22 are installed in the AppVeyor image for Al2023 Windows based project.

How does it address the issue?

Don't need to install python3.13 from the embedded zip file

python --version
Python 3.12.3
set PATH=C:\Python313-x64;%PYTHON_HOME%;C:\Ruby33-x64\bin;C:\Ruby32-x64\bin;%PATH%;C:\Python39-x64;C:\Python310-x64;C:\Python311-x64;C:\Python312-x64;C:\Python313-x64;C:\Python313-x64\Scripts;
python --version
Python 3.13.0
pip --version
pip 24.3.1 from C:\Python312\Lib\site-packages\pip (python 3.12)
node --version
v22.6.0

What side effects does this change have?

no side effects

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hnnasit hnnasit requested a review from a team as a code owner November 18, 2024 21:06
@hnnasit hnnasit added this pull request to the merge queue Nov 18, 2024
Merged via the queue into develop with commit b810417 Nov 18, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants