Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of http:// URLs where possible, and update some old links #2964

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Synchro
Copy link

@Synchro Synchro commented Jul 22, 2024

I was running some static analysis on a project that uses this SDK, and one thing that always gets flagged is http:// URLs, mostly in documentation. Sometimes these are fine (for example for example.com demos, local tests,, or in XML namespaces), but most of the rest don't really have any excuse, and it's just unnecessary noise, so I thought I'd have a go at fixing them!

Anyway, I updated a whole bunch of these. Some changes might not be appropriate, but obvious ones like entries in CHANGELOG, README, composer.json, are worth taking on. I also updated a few documentation links where they had changed (e.g. sensiolabs changing to symfony).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@stobrien89
Copy link
Member

Hi @Synchro,

Thanks for the contribution! We would accept this, but without the modifications to src/data. Those files have upstream (service) sources and changes to those files originating from the SDK will be overwritten the next time the models are updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants