Fixes #1879: Serializes Sets in Response #1881
Conversation
I'm getting an item from a DynamoDB Table that has a set attribute. Simply returning the item at the end of the request through Chalice raises this error: TypeError: Object of type set is not JSON serializable
There was a problem hiding this comment.
Thanks for the PR. Not opposed to the change. I think the original reason for not supporting sets was to match what the default json serializer did in Lambda, but this seems reasonable to me, especially given DynamoDB can return sets.
Had a comment about the test you added, but once that's updated we should be good to merge.
| @@ -1816,6 +1816,17 @@ def test_http_response_to_dict(body, headers, status_code): | |||
| assert isinstance(serialized['body'], six.string_types) | |||
|
|
|||
|
|
|||
| @given(headers=STR_MAP, | |||
There was a problem hiding this comment.
Not sure we need these property based tests for this change. We're passing in varying headers and status code values but our test is just verifying the values of sets. You can probably just create various Response instances and verify the to_dict() serializes the types properly. Something like test_can_encode_binary_body_as_base64().
Probably worth adding an extra test for nested sets as well.
I'm getting an item from a DynamoDB Table that has a set attribute.
Simply returning the item at the end of the request through Chalice
raises this error:
Issue #1879
It handles set as an "extra" type during JSON Serialization.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.