Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert any ChaliceViewError to a response #1886

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

vfrico
Copy link

@vfrico vfrico commented Feb 4, 2022

Description of changes:
Using a method on the class ChaliceViewError would allow any subclass to implement its own custom response for an exception.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@jamesls jamesls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the pull request, seems reasonable to me. I'd like to get a test added to tests/unit/test_app.py that verifies this behavior with a custom subclass to ensure we don't regress on this behavior in the future.

@vfrico
Copy link
Author

vfrico commented Feb 17, 2022

I've just added tests and docs.

On my local machine, the command make prcheck runs ok, but on the last commit the tests didn't ran successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants