Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds presubmits for trigger validations #349

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

jaxesn
Copy link
Member

@jaxesn jaxesn commented Nov 27, 2023

Issue #, if available:

Description of changes:

This should help ensure that we are using the correct bundle and release numbers.

aws/eks-anywhere#7094

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jaxesn jaxesn force-pushed the jgw/add-trigger-validation branch from 83f7f0a to fed7b6c Compare November 27, 2023 23:16
Copy link
Member

@abhay-krishna abhay-krishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 8abf4c6 into aws:main Nov 27, 2023
2 checks passed
@eks-distro-bot
Copy link
Collaborator

@jaxesn: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key eks-anywhere-development-bundle-presubmit.yaml using file jobs/aws/eks-anywhere/eks-anywhere-development-bundle-presubmit.yaml
  • key eks-anywhere-development-eks-a-release-presubmit.yaml using file jobs/aws/eks-anywhere/eks-anywhere-development-eks-a-release-presubmit.yaml
  • key eks-anywhere-production-bundle-presubmit.yaml using file jobs/aws/eks-anywhere/eks-anywhere-production-bundle-presubmit.yaml
  • key eks-anywhere-production-eks-a-release-presubmit.yaml using file jobs/aws/eks-anywhere/eks-anywhere-production-eks-a-release-presubmit.yaml

In response to this:

Issue #, if available:

Description of changes:

This should help ensure that we are using the correct bundle and release numbers.

aws/eks-anywhere#7094

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants