Correct conversion between integer types (#6736) #20329
eks-distro-botAnnotations
10 errors and 10 warnings
|
lint:
internal/pkg/s3/upload.go#L14
exported: exported type UploadOpt should have comment or be unexported (revive)
|
|
lint:
internal/pkg/s3/upload.go#L16
exported: exported function WithPublicRead should have comment or be unexported (revive)
|
|
lint:
internal/pkg/s3/upload.go#L22
exported: exported function UploadFile should have comment or be unexported (revive)
|
|
lint:
internal/pkg/s3/bucket.go#L9
exported: exported function GetBucketPublicURL should have comment or be unexported (revive)
|
|
lint:
internal/pkg/s3/delete.go#L14
exported: exported function CleanUpS3Bucket should have comment or be unexported (revive)
|
|
lint:
internal/pkg/s3/download.go#L14
exported: exported function Download should have comment or be unexported (revive)
|
|
lint:
internal/pkg/s3/object.go#L12
exported: exported function ObjectPresent should have comment or be unexported (revive)
|
|
lint:
internal/pkg/s3/upload.go#L31
exported: exported function Upload should have comment or be unexported (revive)
|
|
lint:
internal/pkg/s3/download.go#L36
exported: exported function DownloadToDisk should have comment or be unexported (revive)
|
|
lint:
pkg/retrier/retrier_test.go#L190
var-declaration: should drop = nil from declaration of var retrier; it is the zero value (revive)
|
|
lint:
pkg/git/providers/github/github.go#L52
unexported-return: exported func New returns unexported type *github.githubProvider, which can be annoying to use (revive)
|
|
lint:
pkg/git/providers/github/github.go#L19
exported: exported const GitProviderName should have comment (or a comment on this block) or be unexported (revive)
|
|
lint:
pkg/git/providers/github/github.go#L33
exported: exported type Options should have comment or be unexported (revive)
|
|
lint:
pkg/git/providers/github/github.go#L40
exported: type name will be used as github.GithubClient by other packages, and that stutters; consider calling this Client (revive)
|
|
lint:
pkg/git/providers/github/github.go#L133
exported: exported function GetGithubAccessTokenFromEnv should have comment or be unexported (revive)
|
|
lint:
pkg/git/providers/github/github.go#L157
exported: exported type GitProviderNotFoundError should have comment or be unexported (revive)
|
|
lint:
pkg/git/providers/github/github.go#L165
exported: exported function RepoUrl should have comment or be unexported (revive)
|
|
lint:
pkg/git/providers/github/github.go#L22
var-naming: const githubUrlTemplate should be githubURLTemplate (revive)
|
|
lint:
pkg/clients/kubernetes/kubeconfig.go#L14
exported: exported function NewKubeconfigClient should have comment or be unexported (revive)
|
|
lint:
pkg/api/v1alpha1/cluster_types.go#L1392
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
|