Bump golangci/golangci-lint-action from 3 to 4 (#7552) #23932
eks-distro-botAnnotations
10 errors and 10 warnings
|
lint:
pkg/retrier/retrier_test.go#L190
var-declaration: should drop = nil from declaration of var retrier; it is the zero value (revive)
|
|
lint:
pkg/retrier/retrier_test.go#L19
increment-decrement: should replace gotRetries += 1 with gotRetries++ (revive)
|
|
lint:
pkg/retrier/retrier_test.go#L39
increment-decrement: should replace gotRetries += 1 with gotRetries++ (revive)
|
|
lint:
pkg/retrier/retrier_test.go#L72
increment-decrement: should replace gotRetries += 1 with gotRetries++ (revive)
|
|
lint:
pkg/retrier/retrier_test.go#L95
increment-decrement: should replace gotRetries += 1 with gotRetries++ (revive)
|
|
lint:
pkg/retrier/retrier_test.go#L118
increment-decrement: should replace gotRetries += 1 with gotRetries++ (revive)
|
|
lint:
pkg/retrier/retrier_test.go#L145
increment-decrement: should replace gotRetries += 1 with gotRetries++ (revive)
|
|
lint:
pkg/retrier/retrier_test.go#L175
increment-decrement: should replace gotRetries += 1 with gotRetries++ (revive)
|
|
lint:
pkg/utils/unstructured/yaml.go#L11
exported: exported function YamlToUnstructured should have comment or be unexported (revive)
|
|
lint:
pkg/utils/unstructured/yaml.go#L16
exported: exported function UnstructuredToYaml should have comment or be unexported (revive)
|
|
lint:
pkg/git/providers/github/github.go#L22
var-naming: const githubUrlTemplate should be githubURLTemplate (revive)
|
|
lint:
pkg/git/providers/github/github.go#L165
var-naming: func RepoUrl should be RepoURL (revive)
|
|
lint:
pkg/git/providers/github/github.go#L19
exported: exported const GitProviderName should have comment (or a comment on this block) or be unexported (revive)
|
|
lint:
pkg/git/providers/github/github.go#L33
exported: exported type Options should have comment or be unexported (revive)
|
|
lint:
pkg/git/providers/github/github.go#L40
exported: type name will be used as github.GithubClient by other packages, and that stutters; consider calling this Client (revive)
|
|
lint:
pkg/git/providers/github/github.go#L52
exported: exported function New should have comment or be unexported (revive)
|
|
lint:
pkg/git/providers/github/github.go#L133
exported: exported function GetGithubAccessTokenFromEnv should have comment or be unexported (revive)
|
|
lint:
pkg/git/providers/github/github.go#L157
exported: exported type GitProviderNotFoundError should have comment or be unexported (revive)
|
|
lint:
pkg/clients/kubernetes/kubeconfig.go#L14
exported: exported function NewKubeconfigClient should have comment or be unexported (revive)
|
|
lint:
pkg/api/v1alpha1/cluster_types.go#L182
receiver-naming: receiver name n should be consistent with previous receiver name c for Cluster (revive)
|