Update CLI logging output to be cluster type aware:

We have been leaking implementation details around
how we create clusters. While CAPI calls the initial
cluster a workload cluster and then pivots its control plane
objects to make it a management cluster this is an
implementation detail that we shouldn't be exposing to
users.

Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>

cmd/eksctl-anywhere/cmd/createcluster.go

@@ -262,7 +262,7 @@ func (cc *createClusterOptions) createCluster(cmd *cobra.Command, _ []string) er
 		err = createWorkloadCluster.Run(ctx, clusterSpec, createValidations)
 
 	} else if clusterSpec.Cluster.IsSelfManaged() {
-		logger.Info("Using the new workflow using the controller for management cluster create")
+		logger.V(1).Info("Using the eksa controller to create the management cluster")
 
 		createMgmtCluster := management.NewCreate(
 			deps.Bootstrapper,

pkg/workflows/management/create_install_eksa.go

@@ -47,7 +47,7 @@ func (s *installEksaComponentsOnWorkloadTask) Run(ctx context.Context, commandCo
 		commandContext.ClusterSpec.Cluster.ClearTinkerbellIPAnnotation()
 	}
 
-	logger.Info("Installing EKS-A custom components on workload cluster")
+	logger.Info("Installing EKS-A custom components on the management cluster")
 
 	err := installEKSAComponents(ctx, commandContext, commandContext.WorkloadCluster)
 	if err != nil {

pkg/workflows/management/create_move_capi.go

@@ -18,7 +18,7 @@ func (s *moveClusterManagementTask) Run(ctx context.Context, commandContext *tas
 		return &workflows.CollectDiagnosticsTask{}
 	}
 
-	logger.Info("Moving cluster management from bootstrap to workload cluster")
+	logger.Info("Moving the cluster management components from the bootstrap cluster to the management cluster")
 	err = commandContext.ClusterManager.MoveCAPI(ctx, commandContext.BootstrapCluster, commandContext.WorkloadCluster, commandContext.WorkloadCluster.Name, commandContext.ClusterSpec, types.WithNodeRef())
 	if err != nil {
 		commandContext.SetError(err)

pkg/workflows/management/create_workload.go

@@ -2,6 +2,7 @@ package management
 
 import (
 	"context"
+	"fmt"
 
 	"github.com/aws/eks-anywhere/pkg/cluster"
 	"github.com/aws/eks-anywhere/pkg/logger"
@@ -13,7 +14,11 @@ import (
 type createWorkloadClusterTask struct{}
 
 func (s *createWorkloadClusterTask) Run(ctx context.Context, commandContext *task.CommandContext) task.Task {
-	logger.Info("Creating new workload cluster")
+	clusterType := "workload"
+	if commandContext.ClusterSpec.Cluster.Name == commandContext.ClusterSpec.ManagementCluster.Name {
+		clusterType = "management"
+	}
+	logger.Info(fmt.Sprintf("Creating new %s cluster", clusterType))
 
 	commandContext.ClusterSpec.Cluster.AddManagedByCLIAnnotation()
 	commandContext.ClusterSpec.Cluster.SetManagementComponentsVersion(commandContext.ClusterSpec.EKSARelease.Spec.Version)
@@ -45,15 +50,15 @@ func (s *createWorkloadClusterTask) Run(ctx context.Context, commandContext *tas
 		return &workflows.CollectDiagnosticsTask{}
 	}
 
-	logger.Info("Installing cluster-api providers on workload cluster")
+	logger.Info(fmt.Sprintf("Installing cluster-api providers on %s cluster", clusterType))
 	managementComponents := cluster.ManagementComponentsFromBundles(commandContext.ClusterSpec.Bundles)
 	err = commandContext.ClusterManager.InstallCAPI(ctx, managementComponents, commandContext.ClusterSpec, commandContext.WorkloadCluster, commandContext.Provider)
 	if err != nil {
 		commandContext.SetError(err)
 		return &workflows.CollectDiagnosticsTask{}
 	}
 
-	logger.Info("Installing EKS-A secrets on workload cluster")
+	logger.Info(fmt.Sprintf("Installing EKS-A secrets on %s cluster", clusterType))
 	err = commandContext.Provider.UpdateSecrets(ctx, commandContext.WorkloadCluster, commandContext.ClusterSpec)
 	if err != nil {
 		commandContext.SetError(err)