Skip to content

Commit

Permalink
Fix 1-30 tests using wrong templates/kube version (#8224)
Browse files Browse the repository at this point in the history
* Fix 1-30 tests using wrong templates/kube version and skip packages tests for 1.30

Signed-off-by: Rahul Ganesh <rahulgab@amazon.com>

* Rebase to factor in new vsphere tests

Signed-off-by: Rahul Ganesh <rahulgab@amazon.com>

---------

Signed-off-by: Rahul Ganesh <rahulgab@amazon.com>
Co-authored-by: Rahul Ganesh <rahulgab@amazon.com>
  • Loading branch information
rahulbabu95 and Rahul Ganesh authored May 28, 2024
1 parent 0e112c0 commit 7abe87c
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 9 deletions.
17 changes: 17 additions & 0 deletions test/e2e/SKIPPED_TESTS.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,23 @@ skipped_tests:
- TestVSphereKubernetes130UbuntuCuratedPackagesClusterAutoscalerSimpleFlow
- TestVSphereKubernetes130UbuntuCuratedPackagesPrometheusSimpleFlow
- TestVSphereKubernetes130UbuntuWorkloadClusterCuratedPackagesSimpleFlow
- TestVSphereKubernetes130BottleRocketWorkloadClusterCuratedPackagesCertManagerSimpleFlow
- TestVSphereKubernetes130UbuntuWorkloadClusterCuratedPackagesCertManagerSimpleFlow
- TestVSphereKubernetes130UbuntuWorkloadClusterCuratedPackagesEmissarySimpleFlow
- TestVSphereKubernetes130BottleRocketCuratedPackagesClusterAutoscalerSimpleFlow
- TestVSphereKubernetes130BottleRocketCuratedPackagesPrometheusSimpleFlow
- TestVSphereKubernetes130BottleRocketWorkloadClusterCuratedPackagesSimpleFlow
- TestVSphereKubernetes130BottleRocketWorkloadClusterCuratedPackagesEmissarySimpleFlow
- TestCloudStackKubernetes130RedhatCuratedPackagesSimpleFlow
- TestCloudStackKubernetes130RedhatCuratedPackagesEmissarySimpleFlow
- TestCloudStackKubernetes130RedhatCuratedPackagesHarborSimpleFlow
- TestCloudStackKubernetes130RedhatWorkloadClusterCuratedPackagesSimpleFlow
- TestCloudStackKubernetes130RedhatCuratedPackagesPrometheusSimpleFlow
- TestCloudStackKubernetes130RedhatCuratedPackagesAdotUpdateFlow
- TestCloudStackKubernetes130RedHatCuratedPackagesClusterAutoscalerSimpleFlow
- TestCloudStackKubernetes130RedhatCuratedPackagesAdotSimpleFlow
- TestCloudStackKubernetes130RedhatCuratedPackagesCertManagerSimpleFlow
- TestCloudStackKubernetes130RedhatWorkloadClusterCuratedPackagesEmissarySimpleFlow

# Snow
- TestSnowKubernetes125SimpleFlow
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/cloudstack_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -932,7 +932,7 @@ func TestCloudStackKubernetes129To130GitFluxUpgrade(t *testing.T) {
test,
v1alpha1.Kube130,
framework.WithClusterUpgrade(api.WithKubernetesVersion(v1alpha1.Kube130)),
provider.WithProviderUpgrade(provider.Redhat9Kubernetes126Template()),
provider.WithProviderUpgrade(provider.Redhat9Kubernetes130Template()),
)
}

Expand Down Expand Up @@ -1766,7 +1766,7 @@ func TestCloudStackKubernetes129To130OIDCUpgrade(t *testing.T) {
)
runUpgradeFlowWithOIDC(
test,
v1alpha1.Kube126,
v1alpha1.Kube130,
framework.WithClusterUpgrade(api.WithKubernetesVersion(v1alpha1.Kube130)),
provider.WithProviderUpgrade(provider.Redhat9Kubernetes130Template()),
)
Expand Down
6 changes: 3 additions & 3 deletions test/e2e/tinkerbell_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ func TestTinkerbellKubernetes129UbuntuTo130UpgradeWorkerOnly(t *testing.T) {
t,
provider,
framework.WithClusterFiller(),
framework.WithClusterFiller(api.WithKubernetesVersion(kube129)),
framework.WithClusterFiller(api.WithKubernetesVersion(kube130)),
framework.WithClusterFiller(api.WithControlPlaneCount(1)),
framework.WithClusterFiller(api.WithWorkerNodeCount(1)),
framework.WithClusterFiller(api.WithWorkerKubernetesVersion(nodeGroupLabel1, &kube129)),
Expand Down Expand Up @@ -1534,7 +1534,7 @@ func TestTinkerbellKubernetes130UbuntuWorkerNodeGroupsTaintsAndLabels(t *testing
framework.WithCustomTinkerbellMachineConfig(nodeGroupLabel2),
),
framework.WithClusterFiller(
api.WithKubernetesVersion(v1alpha1.Kube129),
api.WithKubernetesVersion(v1alpha1.Kube130),
api.WithControlPlaneLabel(cpKey1, cpVal1),
api.WithControlPlaneTaints([]corev1.Taint{framework.NoScheduleTaint()}),
api.RemoveAllWorkerNodeGroups(), // This gives us a blank slate
Expand Down Expand Up @@ -1587,7 +1587,7 @@ func TestTinkerbellAirgappedKubernetes130UbuntuProxyConfigFlow(t *testing.T) {
func TestTinkerbellKubernetes130UbuntuOOB(t *testing.T) {
test := framework.NewClusterE2ETest(
t,
framework.NewTinkerbell(t, framework.WithUbuntu129Tinkerbell()),
framework.NewTinkerbell(t, framework.WithUbuntu130Tinkerbell()),
framework.WithClusterFiller(api.WithKubernetesVersion(v1alpha1.Kube130)),
framework.WithOOBConfiguration(),
framework.WithControlPlaneHardware(1),
Expand Down
8 changes: 4 additions & 4 deletions test/e2e/vsphere_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ func TestVSphereKubernetes130BottleRocketAWSIamAuth(t *testing.T) {
t,
framework.NewVSphere(t, framework.WithBottleRocket130()),
framework.WithAWSIam(),
framework.WithClusterFiller(api.WithKubernetesVersion(v1alpha1.Kube125)),
framework.WithClusterFiller(api.WithKubernetesVersion(v1alpha1.Kube130)),
)
runAWSIamAuthFlow(test)
}
Expand Down Expand Up @@ -2628,7 +2628,7 @@ func TestVSphereKubernetes130BottleRocketWithNTP(t *testing.T) {
test := framework.NewClusterE2ETest(
t,
framework.NewVSphere(
t, framework.WithBottleRocket129(),
t, framework.WithBottleRocket130(),
framework.WithNTPServersForAllMachines(),
framework.WithSSHAuthorizedKeyForAllMachines(""), // set SSH key to empty
),
Expand Down Expand Up @@ -3527,7 +3527,7 @@ func TestVSphereKubernetes130UbuntuControlPlaneNodeUpgrade(t *testing.T) {
)
runSimpleUpgradeFlow(
test,
v1alpha1.Kube129,
v1alpha1.Kube130,
framework.WithClusterUpgrade(api.WithControlPlaneCount(3)),
)
}
Expand Down Expand Up @@ -4150,7 +4150,7 @@ func TestVSphereKubernetes129To130UbuntuInPlaceUpgradeFromLatestMinorRelease(t *
test.GenerateClusterConfigForVersion(release.Version, framework.ExecuteWithEksaRelease(release))
test.UpdateClusterConfig(
api.ClusterToConfigFiller(
api.WithKubernetesVersion(v1alpha1.Kube130),
api.WithKubernetesVersion(v1alpha1.Kube129),
api.WithStackedEtcdTopology(),
),
api.VSphereToConfigFiller(
Expand Down

0 comments on commit 7abe87c

Please sign in to comment.