-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tinkerbell Cluster Autoscaler E2E Test #5884
Add Tinkerbell Cluster Autoscaler E2E Test #5884
Conversation
b2ca973
to
233e9a9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5884 +/- ##
==========================================
- Coverage 71.70% 71.69% -0.01%
==========================================
Files 531 531
Lines 41121 41121
==========================================
- Hits 29486 29483 -3
- Misses 9981 9983 +2
- Partials 1654 1655 +1 ☔ View full report in Codecov by Sentry. |
233e9a9
to
9f7b67d
Compare
/test-all |
/test all |
test/e2e/tinkerbell_test.go
Outdated
|
||
func TestTinkerbellKubernetes127UbuntuCuratedPackagesClusterAutoscalerSimpleFlow(t *testing.T) { | ||
minNodes := 1 | ||
maxNodes := 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we run CheckCuratedPackagesCredentials
there?
test/e2e/tinkerbell_test.go
Outdated
test := framework.NewClusterE2ETest(t, | ||
framework.NewTinkerbell(t, framework.WithUbuntu127Tinkerbell()), | ||
framework.WithClusterFiller(api.WithKubernetesVersion(v1alpha1.Kube127), api.WithWorkerNodeAutoScalingConfig(minNodes, maxNodes)), | ||
framework.WithControlPlaneHardware(1), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why need to set cp node number? I just don't see it else where so if it's default to 1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was following other packages examples here. Searching for WithControlPlaneHardware(1
I do see some other examples, particularly for packages but also for some other types of tests.
I kind of prefer it explicit like this, but if you'd rather I take it out I can do that, just let me know.
9f7b67d
to
3bc4a25
Compare
3bc4a25
to
13d33f1
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
13d33f1
to
14e7ddd
Compare
Bare Metal nodes have a ton of memory, so in order to force a scale up we need a lot of pods and/or a lot of memory requests.
2729a1c
to
62adf94
Compare
@jonathanmeier5: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Issue #, if available:
#5883
Description of changes:
This PR adds an end to end test verifying that cluster autoscaler works on tinkerbell.
Testing (if applicable):
Ran e2e test manually and verified success.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.