Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tinkerbell Cluster Autoscaler E2E Test #5884

Conversation

jonathanmeier5
Copy link
Member

Issue #, if available:
#5883

Description of changes:
This PR adds an end to end test verifying that cluster autoscaler works on tinkerbell.

Testing (if applicable):
Ran e2e test manually and verified success.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 18, 2023
@jonathanmeier5 jonathanmeier5 force-pushed the feature/add-autoscaler-bare-metal-e2e-test branch from b2ca973 to 233e9a9 Compare May 18, 2023 12:25
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (79c297c) 71.70% compared to head (14e7ddd) 71.69%.
Report is 59 commits behind head on main.

❗ Current head 14e7ddd differs from pull request most recent head 62adf94. Consider uploading reports for the commit 62adf94 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5884      +/-   ##
==========================================
- Coverage   71.70%   71.69%   -0.01%     
==========================================
  Files         531      531              
  Lines       41121    41121              
==========================================
- Hits        29486    29483       -3     
- Misses       9981     9983       +2     
- Partials     1654     1655       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonathanmeier5 jonathanmeier5 force-pushed the feature/add-autoscaler-bare-metal-e2e-test branch from 233e9a9 to 9f7b67d Compare July 10, 2023 17:43
@jonathanmeier5
Copy link
Member Author

/test-all

@jonathanmeier5
Copy link
Member Author

/test all


func TestTinkerbellKubernetes127UbuntuCuratedPackagesClusterAutoscalerSimpleFlow(t *testing.T) {
minNodes := 1
maxNodes := 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we run CheckCuratedPackagesCredentials there?

test := framework.NewClusterE2ETest(t,
framework.NewTinkerbell(t, framework.WithUbuntu127Tinkerbell()),
framework.WithClusterFiller(api.WithKubernetesVersion(v1alpha1.Kube127), api.WithWorkerNodeAutoScalingConfig(minNodes, maxNodes)),
framework.WithControlPlaneHardware(1),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why need to set cp node number? I just don't see it else where so if it's default to 1?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was following other packages examples here. Searching for WithControlPlaneHardware(1 I do see some other examples, particularly for packages but also for some other types of tests.

I kind of prefer it explicit like this, but if you'd rather I take it out I can do that, just let me know.

@jonathanmeier5 jonathanmeier5 force-pushed the feature/add-autoscaler-bare-metal-e2e-test branch from 9f7b67d to 3bc4a25 Compare July 10, 2023 20:18
@jonathanmeier5 jonathanmeier5 force-pushed the feature/add-autoscaler-bare-metal-e2e-test branch from 3bc4a25 to 13d33f1 Compare October 5, 2023 17:20
@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jonathanmeier5. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jonathanmeier5 jonathanmeier5 force-pushed the feature/add-autoscaler-bare-metal-e2e-test branch from 13d33f1 to 14e7ddd Compare October 5, 2023 17:22
@eks-distro-bot eks-distro-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 5, 2023
Bare Metal nodes have a ton of memory, so in order to force a scale up we need a lot of pods and/or a lot of memory requests.
@jonathanmeier5 jonathanmeier5 force-pushed the feature/add-autoscaler-bare-metal-e2e-test branch from 2729a1c to 62adf94 Compare October 20, 2023 17:01
@eks-distro-bot
Copy link
Collaborator

@jonathanmeier5: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
eks-anywhere-presubmit 62adf94 link true /test eks-anywhere-presubmit
eks-anywhere-cli-attribution-presubmit 62adf94 link true /test eks-anywhere-cli-attribution-presubmit
eks-anywhere-e2e-presubmit 62adf94 link true /test eks-anywhere-e2e-presubmit
eks-anywhere-e2e-validate-tinkerbell-hardware-presubmit 62adf94 link true /test eks-anywhere-e2e-validate-tinkerbell-hardware-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants