Add setting webhook data via env and cli flags: #5992
Conversation
This enables the use of the Rufio webhook provider. The webhook provider needs a secret and a URL defined. All BMC machines will use this one secret. As part of enabling the webhook secret to be captured by the CLI as an environment variable, all CLI flags are now accessible as env vars. The env var for each flag is the flag name but in all uppercase and the dash "-" symbol converted to an underscore "_". Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Skipping CI for Draft Pull Request. |
eks-distro-bot
added
the
size/L
Codecov Report
@@ Coverage Diff @@
## main #5992 +/- ##
==========================================
- Coverage 73.64% 73.61% -0.03%
==========================================
Files 452 452
Lines 38016 38046 +30
==========================================
+ Hits 27995 28008 +13
- Misses 8396 8412 +16
- Partials 1625 1626 +1
|
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
|
@jacobweinstock: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| for _, modify := range modifiers { | ||
| machine = modify(machine) | ||
| } |
There was a problem hiding this comment.
What do you think about decorating the MachineWriter instead of passing modifiers?
|
Superseded by #6741 |
This enables the use of the Rufio webhook provider. The webhook provider needs a secret and a URL defined. All BMC machines will use this one secret.
As part of enabling the webhook secret to be captured by the CLI as an environment variable, all CLI flags are now accessible as env vars. The env var for each flag is the flag name but in all uppercase and the dash "-" symbol converted to an underscore "_".
Issue #, if available:
Description of changes:
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.