Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #6171 #6658

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Backport #6171 #6658

merged 1 commit into from
Sep 13, 2023

Conversation

chrisdoherty4
Copy link
Contributor

@chrisdoherty4 chrisdoherty4 commented Sep 7, 2023

Depends on #6654.

Manual backport of #6171.

@eks-distro-bot eks-distro-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 7, 2023
@chrisdoherty4 chrisdoherty4 changed the base branch from main to release-0.17 September 7, 2023 18:38
@github-actions github-actions bot added area/docs Documentation documentation and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 7, 2023
@eks-distro-bot eks-distro-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 7, 2023
@eks-distro-bot
Copy link
Collaborator

eks-distro-bot commented Sep 7, 2023

@chrisdoherty4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
eks-anywhere-release-tooling-test-presubmit c216e4f link true /test eks-anywhere-release-tooling-test-presubmit
eks-anywhere-e2e-validate-tinkerbell-hardware-presubmit c216e4f link true /test eks-anywhere-e2e-validate-tinkerbell-hardware-presubmit
eks-anywhere-e2e-presubmit c216e4f link true /test eks-anywhere-e2e-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chrisdoherty4
Copy link
Contributor Author

/retest

@chrisdoherty4
Copy link
Contributor Author

/hold
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisdoherty4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot removed the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 12, 2023
@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 12, 2023
@chrisdoherty4
Copy link
Contributor Author

/unhold

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-0.17@a7a6fb4). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             release-0.17    #6658   +/-   ##
===============================================
  Coverage                ?   75.52%           
===============================================
  Files                   ?      455           
  Lines                   ?    37903           
  Branches                ?        0           
===============================================
  Hits                    ?    28626           
  Misses                  ?     7669           
  Partials                ?     1608           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisdoherty4 chrisdoherty4 requested a review from a team September 13, 2023 12:22
@eks-distro-bot eks-distro-bot merged commit df2378c into aws:release-0.17 Sep 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants