Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cli upgrade mgmt kubeconfig flag #6666

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

ddjjia
Copy link
Contributor

@ddjjia ddjjia commented Sep 8, 2023

Issue #, if available:
#5905

Description of changes:
We decide to separate bug fix and flag deprecation.

eksa upgrade cluster -f mgmt.yaml --kubeconfig cluster.kubeconfig (only kubeconfig is provided)

  • set wconfig to provided cluster.kubeconfig
  • set mgmtkubeconfig to empty
input --w-config input --kubeconfig input file actual wconfig value actual mgmtkubeconfig value expected behavior
  mgmt mgmt reset to mgmt reset to "" upgrade mgmt
  wl mgmt wl "" error wl kubeconfig doesn't have resource cluster
  mgmt wl default location mgmt upgrade wl cluster
  wl wl default location wl error wl kubeconfig doesn't have resource cluster
mgmt   mgmt mgmt "" upgrade mgmt
wl   mgmt wl "" error wl kubeconfig doesn't have resource cluster
mgmt   wl mgmt default location upgrade wl
wl   wl wl default location upgrade wl
wl mgmt wl wl mgmt upgrade wl
mgmt wl wl mgmt wl error wl kubeconfig doesn't have resource cluster
wl mgmt mgmt wl "" error wl kubeconfig doesn't have resource cluster
mgmt wl mgmt mgmt wl upgrade mgmt cluster

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 8, 2023
@eks-distro-bot eks-distro-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03% ⚠️

Comparison is base (a07878f) 75.65% compared to head (406e8ec) 75.62%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6666      +/-   ##
==========================================
- Coverage   75.65%   75.62%   -0.03%     
==========================================
  Files         473      473              
  Lines       38189    38234      +45     
==========================================
+ Hits        28892    28916      +24     
- Misses       7702     7721      +19     
- Partials     1595     1597       +2     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@vivek-koppuru vivek-koppuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for showing this matrix! We can in the follow up PR where we deprecate w-config fix how kubeconfig is used

@ddjjia
Copy link
Contributor Author

ddjjia commented Sep 8, 2023

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ddjjia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 4454e7b into aws:main Sep 8, 2023
5 checks passed
@ddjjia
Copy link
Contributor Author

ddjjia commented Sep 13, 2023

/cherry-pick release-0.17

@eks-distro-pr-bot
Copy link
Contributor

@ddjjia: new pull request created: #6679

In response to this:

/cherry-pick release-0.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants