-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix cli upgrade mgmt kubeconfig flag #6666
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #6666 +/- ##
==========================================
- Coverage 75.65% 75.62% -0.03%
==========================================
Files 473 473
Lines 38189 38234 +45
==========================================
+ Hits 28892 28916 +24
- Misses 7702 7721 +19
- Partials 1595 1597 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for showing this matrix! We can in the follow up PR where we deprecate w-config fix how kubeconfig is used
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ddjjia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-0.17 |
@ddjjia: new pull request created: #6679 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue #, if available:
#5905
Description of changes:
We decide to separate bug fix and flag deprecation.
eksa upgrade cluster -f mgmt.yaml --kubeconfig cluster.kubeconfig
(only kubeconfig is provided)Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.