Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.17] Fix side effect of unnecessary workload cluster machine rollout #6669

Conversation

eks-distro-pr-bot
Copy link
Contributor

This is an automated cherry-pick of #6667

/assign jiayiwang7

@eks-distro-bot
Copy link
Collaborator

Hi @eks-distro-pr-bot. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot added needs-ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 8, 2023
@jiayiwang7
Copy link
Member

/approve
/lgtm

…g management cluster upgrade due to package reconcile error
@eks-distro-pr-bot eks-distro-pr-bot force-pushed the cherry-pick-6667-to-release-0.17 branch from 9931848 to 2f3f9ce Compare September 8, 2023 21:13
@jiayiwang7
Copy link
Member

/approve
/lgtm

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiayiwang7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-0.17@d9014be). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             release-0.17    #6669   +/-   ##
===============================================
  Coverage                ?   75.48%           
===============================================
  Files                   ?      454           
  Lines                   ?    37820           
  Branches                ?        0           
===============================================
  Hits                    ?    28548           
  Misses                  ?     7666           
  Partials                ?     1606           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eks-distro-bot eks-distro-bot merged commit 9eb9927 into aws:release-0.17 Sep 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants