-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix airgapped optional docs #6737
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6737 +/- ##
=======================================
Coverage 75.66% 75.66%
=======================================
Files 475 475
Lines 38359 38359
=======================================
Hits 29023 29023
Misses 7727 7727
Partials 1609 1609 ☔ View full report in Codecov by Sentry. |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-0.17 |
@chrisnegus: once the present PR merges, I will cherry-pick it on top of release-0.17 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@chrisnegus: new pull request created: #6739 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of changes: Optional airgapped instructions from the airgap-steps.md file were not appearing in the text when that file was read into getting-started/airgapped/airgap-steps.md and clustermgmt/cluster-upgrades/airgapped-upgrades.md files. To fix that, I moved that content directly into the airgap-steps.md file.