Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix airgapped optional docs #6737

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Conversation

chrisnegus
Copy link
Member

Description of changes: Optional airgapped instructions from the airgap-steps.md file were not appearing in the text when that file was read into getting-started/airgapped/airgap-steps.md and clustermgmt/cluster-upgrades/airgapped-upgrades.md files. To fix that, I moved that content directly into the airgap-steps.md file.

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 27, 2023
@chrisnegus chrisnegus removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7603335) 75.66% compared to head (343df91) 75.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6737   +/-   ##
=======================================
  Coverage   75.66%   75.66%           
=======================================
  Files         475      475           
  Lines       38359    38359           
=======================================
  Hits        29023    29023           
  Misses       7727     7727           
  Partials     1609     1609           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 27, 2023
@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chrisnegus
Copy link
Member Author

/cherry-pick release-0.17

@eks-distro-pr-bot
Copy link
Contributor

@chrisnegus: once the present PR merges, I will cherry-pick it on top of release-0.17 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot merged commit 85925e4 into aws:main Sep 27, 2023
5 checks passed
@eks-distro-pr-bot
Copy link
Contributor

@chrisnegus: new pull request created: #6739

In response to this:

/cherry-pick release-0.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/docs Documentation documentation lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants