Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure gitOps during kindless management cluster #6771

Merged

Conversation

panktishah26
Copy link
Member

Description of changes:
We don't allow to configure gitOps for management cluster upgrade. For kindless management upgrade flow, we use controller to upgrade our cluster so this PR allows configuring gitOps for the management cluster if the kindless feature is enabled.

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (17d6a80) 71.73% compared to head (7334caf) 71.76%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6771      +/-   ##
==========================================
+ Coverage   71.73%   71.76%   +0.03%     
==========================================
  Files         531      531              
  Lines       41064    41278     +214     
==========================================
+ Hits        29456    29625     +169     
- Misses       9962     9993      +31     
- Partials     1646     1660      +14     
Files Coverage Δ
pkg/api/v1alpha1/cluster_webhook.go 92.90% <100.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panktishah26 panktishah26 force-pushed the gitflux-validation-kindless-upgrade branch from a24eeb5 to d180002 Compare October 6, 2023 00:36
@panktishah26 panktishah26 force-pushed the gitflux-validation-kindless-upgrade branch from d180002 to 7334caf Compare October 6, 2023 01:45
@eks-distro-bot eks-distro-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 6, 2023
Copy link
Member

@g-gaston g-gaston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 2de41c8 into aws:main Oct 6, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants