Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.28 Vsphere E2E #6773

Merged
merged 4 commits into from
Oct 6, 2023
Merged

Add 1.28 Vsphere E2E #6773

merged 4 commits into from
Oct 6, 2023

Conversation

tatlat
Copy link
Member

@tatlat tatlat commented Oct 5, 2023

Issue #, if available:

Description of changes:

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (79c297c) 71.70% compared to head (2356eaa) 71.70%.
Report is 2 commits behind head on main.

❗ Current head 2356eaa differs from pull request most recent head e777134. Consider uploading reports for the commit e777134 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6773   +/-   ##
=======================================
  Coverage   71.70%   71.70%           
=======================================
  Files         531      531           
  Lines       41121    41121           
=======================================
  Hits        29486    29486           
  Misses       9981     9981           
  Partials     1654     1654           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhay-krishna
Copy link
Member

/lgtm

@tatlat
Copy link
Member Author

tatlat commented Oct 6, 2023

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tatlat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit b71cfa3 into aws:main Oct 6, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants