Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Audit Logging in Tinkerbell Cluster [release-0.17] #6779

Merged

Conversation

tatlat
Copy link
Member

@tatlat tatlat commented Oct 5, 2023

Issue #, if available:

Description of changes:

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 5, 2023
@tatlat tatlat changed the title Enable Audit Logging in Tinkerbell Cluster Enable Audit Logging in Tinkerbell Cluster [release-0.17] Oct 5, 2023
@jiayiwang7
Copy link
Member

/lgtm

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release-0.17@e84443e). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff               @@
##             release-0.17    #6779   +/-   ##
===============================================
  Coverage                ?   75.51%           
===============================================
  Files                   ?      455           
  Lines                   ?    37922           
  Branches                ?        0           
===============================================
  Hits                    ?    28638           
  Misses                  ?     7674           
  Partials                ?     1610           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tatlat
Copy link
Member Author

tatlat commented Oct 5, 2023

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tatlat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 972f40b into aws:release-0.17 Oct 5, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants